| Message ID | 1391839441-21006-3-git-send-email-b32955@freescale.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sat, Feb 08, 2014 at 02:03:58PM +0800, Huang Shijie wrote: > Add the jedec_version field, and add an anonymous union which > contains the nand_onfi_params and nand_jedec_params. > > Signed-off-by: Huang Shijie <b32955@freescale.com> > --- > include/linux/mtd/nand.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index 588f8a4..9686390 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -664,7 +664,11 @@ struct nand_chip { > int badblockbits; > > int onfi_version; > - struct nand_onfi_params onfi_params; > + int jedec_version; > + union { > + struct nand_onfi_params onfi_params; > + struct nand_jedec_params jedec_params; Can you document the new fields in the kerneldoc comments above struct nand_chip? > + }; > > int read_retries; > Brian
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index 588f8a4..9686390 100644 --- a/include/linux/mtd/nand.h +++ b/include/linux/mtd/nand.h @@ -664,7 +664,11 @@ struct nand_chip { int badblockbits; int onfi_version; - struct nand_onfi_params onfi_params; + int jedec_version; + union { + struct nand_onfi_params onfi_params; + struct nand_jedec_params jedec_params; + }; int read_retries;
Add the jedec_version field, and add an anonymous union which contains the nand_onfi_params and nand_jedec_params. Signed-off-by: Huang Shijie <b32955@freescale.com> --- include/linux/mtd/nand.h | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)