diff mbox

mtd:elm: Use correct check on return value of pm_runtime_get_sync

Message ID 1391439249-23078-1-git-send-email-stefan.sorensen@spectralink.com
State Accepted
Commit 0a21552a6e8ab9d3bacd490f5b94a178ce4d661d
Headers show

Commit Message

Sørensen, Stefan Feb. 3, 2014, 2:54 p.m. UTC 
The ELM driver incorrectly reagard any non-zero return value from
pm_runtime_get_sync as an error, but it may return 1 if the device
was already active. Fix to only error when return value is negative.

Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
---
 drivers/mtd/devices/elm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Brian Norris Feb. 11, 2014, 6:45 p.m. UTC | #1 
On Mon, Feb 03, 2014 at 03:54:09PM +0100, Stefan Sørensen wrote:
> The ELM driver incorrectly reagard any non-zero return value from
> pm_runtime_get_sync as an error, but it may return 1 if the device
> was already active. Fix to only error when return value is negative.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>

Pushed to l2-mtd.git. Thanks!

Brian
diff mbox

Patch

diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index d1dd6a3..e2c073c 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -380,7 +380,7 @@  static int elm_probe(struct platform_device *pdev)
 	}
 
 	pm_runtime_enable(&pdev->dev);
-	if (pm_runtime_get_sync(&pdev->dev)) {
+	if (pm_runtime_get_sync(&pdev->dev) < 0) {
 		ret = -EINVAL;
 		pm_runtime_disable(&pdev->dev);
 		dev_err(&pdev->dev, "can't enable clock\n");