From patchwork Mon Mar 18 11:18:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huang Shijie X-Patchwork-Id: 228477 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0A59C2C0129 for ; Mon, 18 Mar 2013 23:28:51 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UHZA5-0006qa-1u; Mon, 18 Mar 2013 12:27:33 +0000 Received: from ch1ehsobe001.messaging.microsoft.com ([216.32.181.181] helo=ch1outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UHY9I-0008Uy-B4 for linux-mtd@lists.infradead.org; Mon, 18 Mar 2013 11:22:42 +0000 Received: from mail129-ch1-R.bigfish.com (10.43.68.241) by CH1EHSOBE006.bigfish.com (10.43.70.56) with Microsoft SMTP Server id 14.1.225.23; Mon, 18 Mar 2013 11:22:37 +0000 Received: from mail129-ch1 (localhost [127.0.0.1]) by mail129-ch1-R.bigfish.com (Postfix) with ESMTP id 1DC61400105; Mon, 18 Mar 2013 11:22:37 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: 5 X-BigFish: VS5(z616jzzz1f42h1ee6h1de0h1202h1e76h1d1ah1d2ah1082kzz8275bhz2dh2a8h668h839hd24he5bhf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1155h) Received: from mail129-ch1 (localhost.localdomain [127.0.0.1]) by mail129-ch1 (MessageSwitch) id 1363605755240176_1719; Mon, 18 Mar 2013 11:22:35 +0000 (UTC) Received: from CH1EHSMHS025.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.246]) by mail129-ch1.bigfish.com (Postfix) with ESMTP id 2E6D54E0093; Mon, 18 Mar 2013 11:22:35 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CH1EHSMHS025.bigfish.com (10.43.70.25) with Microsoft SMTP Server (TLS) id 14.1.225.23; Mon, 18 Mar 2013 11:22:30 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-002.039d.mgd.msft.net (10.84.1.15) with Microsoft SMTP Server (TLS) id 14.2.328.11; Mon, 18 Mar 2013 11:22:29 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id r2IBM63B021313; Mon, 18 Mar 2013 04:22:27 -0700 From: Huang Shijie To: Subject: [PATCH 06/11] mtd: get the ECC info from the Extended Parameter Page Date: Mon, 18 Mar 2013 19:18:49 +0800 Message-ID: <1363605534-24776-7-git-send-email-b32955@freescale.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1363605534-24776-1-git-send-email-b32955@freescale.com> References: <1363605534-24776-1-git-send-email-b32955@freescale.com> MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130318_072240_459049_E9A32017 X-CRM114-Status: GOOD ( 15.17 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [216.32.181.181 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Huang Shijie , computersforpeace@gmail.com, linux-mtd@lists.infradead.org, matthieu.castet@parrot.com, dedekind1@gmail.com X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since the ONFI 2.1, the onfi spec adds the Extended Parameter Page to store the ECC info. The onfi spec tells us that if the nand chip's recommended ECC codeword size is not 512 bytes, then the @ecc_bits is 0xff. The host _SHOULD_ then read the Extended ECC information that is part of the extended parameter page to retrieve the ECC requirements for this device. This patch implement the reading of the Extended Parameter Page, and parses the sections for ECC type, and get the ECC info from the ECC section. Tested this patch with Micron MT29F64G08CBABAWP. Signed-off-by: Huang Shijie --- drivers/mtd/nand/nand_base.c | 54 ++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 54 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 461fbc8..f1cc1b9 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -2813,6 +2813,56 @@ static u16 onfi_crc16(u16 crc, u8 const *p, size_t len) return crc; } +/* Parse the Extended Parameter Page. */ +static void nand_flash_detect_ext_param_page(struct mtd_info *mtd, + struct nand_chip *chip, struct nand_onfi_params *p, int last) +{ + struct ext_param_page *ep; + struct ext_section *s; + struct ext_ecc_info *ecc; + uint8_t *cursor; + int len; + int i; + + len = le16_to_cpu(p->ext_param_page_length) * 16; + ep = kcalloc(1, max_t(int, len, sizeof(*p)), GFP_KERNEL); + if (!ep) + goto ext_out; + + /* + * Skip the ONFI Parameter Pages. + * The Change Read Columm command may does not works here. + */ + for (i = last + 1; i < p->num_of_param_pages; i++) + chip->read_buf(mtd, (uint8_t *)ep, sizeof(*p)); + + /* Read out the Extended Parameter Page. */ + chip->read_buf(mtd, (uint8_t *)ep, len); + if ((onfi_crc16(ONFI_CRC_BASE, ((uint8_t *)ep) + 2, len - 2) + != le16_to_cpu(ep->crc)) || strncmp(ep->sig, "EPPS", 4)) + goto ext_out; + + /* find the ECC section. */ + cursor = (uint8_t *)(ep + 1); + for (i = 0; i < EXT_SECTION_MAX; i++) { + s = ep->sections + i; + if (s->type == SECTION_TYPE_2) + break; + cursor += s->length * 16; + } + if (i == EXT_SECTION_MAX) + goto ext_out; + + /* get the info we want. */ + ecc = (struct ext_ecc_info *)cursor; + chip->ecc_strength = ecc->ecc_bits; + chip->ecc_size = 1 << ecc->codeword_size; + + pr_info("ONFI extended param page detected.\n"); +ext_out: + kfree(ep); +} + /* * Check if the NAND chip is ONFI compliant, returns 1 if it is, 0 otherwise. */ @@ -2881,6 +2931,10 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip, if (p->ecc_bits != 0xff) { chip->ecc_strength = p->ecc_bits; chip->ecc_size = 512; + } else if (chip->onfi_version >= 21 && + (onfi_get_feature(chip) & ONFI_FEATURE_EXT_PARAM_PAGE)) { + /* The Extended Parameter Page is supported since ONFI 2.1. */ + nand_flash_detect_ext_param_page(mtd, chip, p, i); } pr_info("ONFI flash detected\n");