| Message ID | 1359368750-19763-3-git-send-email-zajec5@gmail.com |
|---|---|
| State | Accepted |
| Commit | 0fca6ab4e1761783acd393cbc55878f0522e1c4b |
| Headers | show |
On Mon, 2013-01-28 at 11:25 +0100, Rafał Miłecki wrote: > From: Hauke Mehrtens <hauke@hauke-m.de> > > This is not a serial flash driver, but a nand flash driver > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > V2: break line to match 80 chars When sending v2 for individual patches, please, remember 2 things: 1. Keep them part of the original thread (ensure correct In-Reply-To:). 2. Add your own signed-off-by. Thanks! P.S. I took your versions of patches, thanks!
2013/2/4 Artem Bityutskiy <dedekind1@gmail.com>: > On Mon, 2013-01-28 at 11:25 +0100, Rafał Miłecki wrote: >> From: Hauke Mehrtens <hauke@hauke-m.de> >> >> This is not a serial flash driver, but a nand flash driver >> >> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> >> --- >> V2: break line to match 80 chars > > When sending v2 for individual patches, please, remember 2 things: > > 1. Keep them part of the original thread (ensure correct In-Reply-To:). Whoops, I've to learn how to make that with git send-email. > 2. Add your own signed-off-by. It was so trivial... I wasn't sure if it's worth signing-it-by... ;)
On Mon, 2013-02-04 at 09:42 +0100, Rafał Miłecki wrote: > 2013/2/4 Artem Bityutskiy <dedekind1@gmail.com>: > > On Mon, 2013-01-28 at 11:25 +0100, Rafał Miłecki wrote: > >> From: Hauke Mehrtens <hauke@hauke-m.de> > >> > >> This is not a serial flash driver, but a nand flash driver > >> > >> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > >> --- > >> V2: break line to match 80 chars > > > > When sending v2 for individual patches, please, remember 2 things: > > > > 1. Keep them part of the original thread (ensure correct In-Reply-To:). > > Whoops, I've to learn how to make that with git send-email. --in-reply-to=<identifier> Pick the identifier from the Message-ID tag of the e-mail you are replying to. E.g., save the e-mail as hauke.mbox file and do: $ grep -i '^Message-ID:' hauke.mbox Message-Id: <1359045599-1305-2-git-send-email-hauke@hauke-m.de> which means that for this one the 'git send-email' option will be: --in-reply-to="<1359045599-1305-2-git-send-email-hauke@hauke-m.de>" > > 2. Add your own signed-off-by. > > It was so trivial... I wasn't sure if it's worth signing-it-by... ;) Signed-off-by is not about how big were your changes, it roughly speaking means that you confirm that the source of this patch for you is Hauke Mehrtens. See Documentation/SubmittingPatches The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. I googled a bit and found also this: http://kerneltrap.org/files/Jeremy/DCO.txt which gives additional clue about what can be behind SOB.
diff --git a/drivers/mtd/nand/bcm47xxnflash/main.c b/drivers/mtd/nand/bcm47xxnflash/main.c index 8363a9a..3e20762 100644 --- a/drivers/mtd/nand/bcm47xxnflash/main.c +++ b/drivers/mtd/nand/bcm47xxnflash/main.c @@ -94,7 +94,8 @@ static int __init bcm47xxnflash_init(void) */ err = platform_driver_probe(&bcm47xxnflash_driver, bcm47xxnflash_probe); if (err) - pr_err("Failed to register serial flash driver: %d\n", err); + pr_err("Failed to register bcm47xx nand flash driver: %d\n", + err); return err; }