| Message ID | 1358933176-12409-2-git-send-email-avinashphilip@ti.com |
|---|---|
| State | Not Applicable |
| Headers | show |
* Philip Avinash <avinashphilip@ti.com> [130123 01:28]: > With recent GPMC driver conversion, usage of gpmc_save/restore_context > can done from gpmc driver itself. Hence removes the usage from pm34xx.c. > Also removes the conditional compilation primitives ARCH_OMAP3 for > gpmc_save/restore_context. Hmm I think this will break GPMC for deeper idle modes. Note that we need to save and restore the context every time hitting off-idle, not just for suspend and resume. Or am I missing something here? Regards, Tony
On Sat, Feb 02, 2013 at 03:35:10, Tony Lindgren wrote: > * Philip Avinash <avinashphilip@ti.com> [130123 01:28]: > > With recent GPMC driver conversion, usage of gpmc_save/restore_context > > can done from gpmc driver itself. Hence removes the usage from pm34xx.c. > > Also removes the conditional compilation primitives ARCH_OMAP3 for > > gpmc_save/restore_context. > > Hmm I think this will break GPMC for deeper idle modes. Note that we > need to save and restore the context every time hitting off-idle, not > just for suspend and resume. Or am I missing something here? I understand dependency on idle modes. So I will send a second version with this patch eliminated so that user initiated suspend/resume work for am335x platforms. Thanks Avinash > > Regards, > > Tony >
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index cbf4e0d..aed958a 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2/gpmc.c @@ -1426,7 +1426,6 @@ static irqreturn_t gpmc_handle_irq(int irq, void *dev) return IRQ_HANDLED; } -#ifdef CONFIG_ARCH_OMAP3 static struct omap3_gpmc_regs gpmc_context; void omap3_gpmc_save_context(void) @@ -1491,4 +1490,3 @@ void omap3_gpmc_restore_context(void) } } } -#endif /* CONFIG_ARCH_OMAP3 */ diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 60fbf0a..cab4c5d 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -43,7 +43,6 @@ #include "common.h" #include "cm3xxx.h" #include "cm-regbits-34xx.h" -#include "gpmc.h" #include "prm-regbits-34xx.h" #include "prm3xxx.h" #include "pm.h" @@ -84,8 +83,6 @@ static void omap3_core_save_context(void) /* Save the Interrupt controller context */ omap_intc_save_context(); - /* Save the GPMC context */ - omap3_gpmc_save_context(); /* Save the system control module context, padconf already save above*/ omap3_control_save_context(); omap_dma_global_context_save(); @@ -95,8 +92,6 @@ static void omap3_core_restore_context(void) { /* Restore the control module context, padconf restored by h/w */ omap3_control_restore_context(); - /* Restore the GPMC context */ - omap3_gpmc_restore_context(); /* Restore the interrupt controller context */ omap_intc_restore_context(); omap_dma_global_context_restore();
With recent GPMC driver conversion, usage of gpmc_save/restore_context can done from gpmc driver itself. Hence removes the usage from pm34xx.c. Also removes the conditional compilation primitives ARCH_OMAP3 for gpmc_save/restore_context. Signed-off-by: Philip Avinash <avinashphilip@ti.com> --- arch/arm/mach-omap2/gpmc.c | 2 -- arch/arm/mach-omap2/pm34xx.c | 5 ----- 2 files changed, 7 deletions(-)