| Message ID | 1282332973-12077-2-git-send-email-norris@broadcom.com |
|---|---|
| State | Accepted |
| Commit | 5c709ee9f33da4a07d94e3d48b297eb6f003fc61 |
| Headers | show |
On Fri, 2010-08-20 at 12:36 -0700, Brian Norris wrote: > An increase in NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE is necessary > in order to support many new chips. Among those: > > Toshiba TC58TxG4S2FBAxx 8KB page, 576B OOB > Micron MT29F64G08CBAAA 8KB page, 448B OOB Ick, don't we have a better fix for this in the works?
On 08/20/2010 12:43 PM, David Woodhouse wrote: > On Fri, 2010-08-20 at 12:36 -0700, Brian Norris wrote: >> An increase in NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE is necessary >> in order to support many new chips. Among those: >> >> Toshiba TC58TxG4S2FBAxx 8KB page, 576B OOB >> Micron MT29F64G08CBAAA 8KB page, 448B OOB > > Ick, don't we have a better fix for this in the works? > For the MAX macros? I have no idea. There were comments there telling me to do this whenever newer chips are supported.
On Fri, 2010-08-20 at 14:28 -0700, Brian Norris wrote: > For the MAX macros? I have no idea. There were comments there telling > me to do this whenever newer chips are supported. I was thinking of the nand_ecc_layout stuff, I think. Perhaps these buffers should be dynamically allocated and we should ditch the MAX macros altogether?
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index 102e12c..a8921c2 100644 --- a/include/linux/mtd/nand.h +++ b/include/linux/mtd/nand.h @@ -53,8 +53,8 @@ extern int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len); * is supported now. If you add a chip with bigger oobsize/page * adjust this accordingly. */ -#define NAND_MAX_OOBSIZE 256 -#define NAND_MAX_PAGESIZE 4096 +#define NAND_MAX_OOBSIZE 576 +#define NAND_MAX_PAGESIZE 8192 /* * Constants for hardware specific CLE/ALE/NCE function
An increase in NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE is necessary in order to support many new chips. Among those: Toshiba TC58TxG4S2FBAxx 8KB page, 576B OOB Micron MT29F64G08CBAAA 8KB page, 448B OOB Signed-off-by: Brian Norris <norris@broadcom.com> --- include/linux/mtd/nand.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)