From patchwork Thu Feb 6 06:14:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 317361 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D2A6D2C0079 for ; Thu, 6 Feb 2014 17:15:28 +1100 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WBIEy-0005wb-IW; Thu, 06 Feb 2014 06:15:12 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WBIEm-0003bI-NF; Thu, 06 Feb 2014 06:15:00 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WBIEj-0003Zb-8K for linux-mtd@lists.infradead.org; Thu, 06 Feb 2014 06:14:59 +0000 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N0K00GYO9CAQYB0@mailout1.samsung.com> for linux-mtd@lists.infradead.org; Thu, 06 Feb 2014 15:14:34 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 82.15.10092.A4823F25; Thu, 06 Feb 2014 15:14:34 +0900 (KST) X-AuditID: cbfee68f-b7f156d00000276c-f6-52f3284ac385 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id A1.38.28157.A4823F25; Thu, 06 Feb 2014 15:14:34 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N0K005UO9CA6WE1@mmp2.samsung.com>; Thu, 06 Feb 2014 15:14:34 +0900 (KST) From: Jingoo Han To: 'Brian Norris' References: <000201cf2301$b168d250$143a76f0$%han@samsung.com> In-reply-to: <000201cf2301$b168d250$143a76f0$%han@samsung.com> Subject: [PATCH 5/8] mtd: lpddr: Remove unnecessary OOM messages Date: Thu, 06 Feb 2014 15:14:33 +0900 Message-id: <000701cf2302$b477a380$1d66ea80$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac8jAbE1WngzMHtDT6iqHUbMRstK1wAALGeA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t8zA10vjc9BBqt7RS2OXFjLbDFx5WRm i8sLL7Fa7G5axu7A4rFz1l12j80rtDw2L6n36NuyijGAJYrLJiU1J7MstUjfLoEro2f3BbaC pdwVF7bOZ29gXMfZxcjJISFgInHv21t2CFtM4sK99WxdjFwcQgLLGCXebrjIAlN0ZvIjZojE dEaJhl1nWCGcX4wSr3d+ZgOpYhNQk/jy5TDQKA4OEQEDiR9vMkHCzAIFEi1tr8A2CAnYSvyb tpUVxOYUsJP4/u852AJhAQeJ52svgsVZBFQlzk65C2bzAtV/nv0WyhaU+DH5HgvETC2J9TuP M0HY8hKb17xlBlkrIaAu8eivLkhYRMBI4sPqe8wQJSIS+168YwQ5WULgHLvEyjd3mSB2CUh8 m3yIBaJXVmLTAWaIfyUlDq64wTKBUWIWks2zkGyehWTzLCQrFjCyrGIUTS1ILihOSi8y1itO zC0uzUvXS87P3cQIicn+HYx3D1gfYkwGWj+RWUo0OR8Y03kl8YbGZkYWpiamxkbmlmakCSuJ 895/mBQkJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgVGv1KaiiXNG8YmmFQdecKxjr/nfqLrW bc6y4OnyE53OvN+dckVhsXev3X5JUa6TlxYXpKlyO3oXvmN1/hX1NvmcWYm3Q+uqztBQmVU2 zh8jK9T3Lg6+IX6qeJuQafbTiOcZ5+yPqGUv90+x6t2rt+rYp2NPa8U3Pr2pvnjJfA7+/Re8 l/LGliuxFGckGmoxFxUnAgC+oIki3wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsVy+t9jQV0vjc9BBu3rBC2OXFjLbDFx5WRm i8sLL7Fa7G5axu7A4rFz1l12j80rtDw2L6n36NuyijGAJaqB0SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaKWSQlliTilQKCCxuFhJ3w7ThNAQN10L mMYIXd+QILgeIwM0kLCOMaNn9wW2gqXcFRe2zmdvYFzH2cXIySEhYCJxZvIjZghbTOLCvfVs XYxcHEIC0xklGnadYYVwfjFKvN75mQ2kik1ATeLLl8PsXYwcHCICBhI/3mSChJkFCiRa2l6x g9hCArYS/6ZtZQWxOQXsJL7/e84CYgsLOEg8X3sRLM4ioCpxdspdMJsXqP7z7LdQtqDEj8n3 WCBmakms33mcCcKWl9i85i0zyFoJAXWJR391QcIiAkYSH1bfY4YoEZHY9+Id4wRGoVlIJs1C MmkWkkmzkLQsYGRZxSiaWpBcUJyUnmukV5yYW1yal66XnJ+7iREc8c+kdzCuarA4xCjAwajE w7th/acgIdbEsuLK3EOMEhzMSiK8F58DhXhTEiurUovy44tKc1KLDzEmAz06kVlKNDkfmIzy SuINjU3MjCyNzCyMTMzNSRNWEuc92GodKCSQnliSmp2aWpBaBLOFiYNTqoHR9qdWhH6AUBNX 9o+vqmXvBfJSTojXXrFYOe1N3dvZFflubarWO59uaBA9azw9Y4Fk4MK4llauO3diH8wNsivy PuT3eHdXw/+Jrz+psxmKrPKzvjvBR1rS5vHsI1NOZquskv/f0Oe+mZ2J+eI/BoHVi0VW19/f V6nZzByzroerSu3TQzcFgx9KLMUZiYZazEXFiQCthFd2PAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140206_011457_535994_CE7A2FF4 X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.4 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.24 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.5 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-mtd@lists.infradead.org, 'Jingoo Han' , 'David Woodhouse' X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han --- drivers/mtd/lpddr/lpddr_cmds.c | 4 +--- drivers/mtd/lpddr/qinfo_probe.c | 5 +---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c index d38b646..018c75f 100644 --- a/drivers/mtd/lpddr/lpddr_cmds.c +++ b/drivers/mtd/lpddr/lpddr_cmds.c @@ -55,10 +55,8 @@ struct mtd_info *lpddr_cmdset(struct map_info *map) int i, j; mtd = kzalloc(sizeof(*mtd), GFP_KERNEL); - if (!mtd) { - printk(KERN_ERR "Failed to allocate memory for MTD device\n"); + if (!mtd) return NULL; - } mtd->priv = map; mtd->type = MTD_NORFLASH; diff --git a/drivers/mtd/lpddr/qinfo_probe.c b/drivers/mtd/lpddr/qinfo_probe.c index 45abed6..69f2112 100644 --- a/drivers/mtd/lpddr/qinfo_probe.c +++ b/drivers/mtd/lpddr/qinfo_probe.c @@ -135,11 +135,8 @@ static int lpddr_chip_setup(struct map_info *map, struct lpddr_private *lpddr) { lpddr->qinfo = kzalloc(sizeof(struct qinfo_chip), GFP_KERNEL); - if (!lpddr->qinfo) { - printk(KERN_WARNING "%s: no memory for LPDDR qinfo structure\n", - map->name); + if (!lpddr->qinfo) return 0; - } /* Get the ManuID */ lpddr->ManufactId = CMDVAL(map_read(map, map->pfow_base + PFOW_MANUFACTURER_ID));