From patchwork Wed Apr 10 22:42:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Hutchings X-Patchwork-Id: 1922268 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=hCvyZPls; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mind.be header.i=@mind.be header.a=rsa-sha256 header.s=google header.b=gSv368RM; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VFHsk5rcpz1yY8 for ; Thu, 11 Apr 2024 08:43:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VMoFLIrf3l3ggwzRhOoQg4G2rfNITi4oT6p0xbTscCM=; b=hCvyZPlsIRMOfr 5G/SKAoqyrljBUqpmta3JWc/GoJ38no1z0HXHqld1WmxZnU0Ao6YbTNulQ6XMOowLy7dmiwCvE/Sx npZbP//nlN5tJONDNT/i60S01aTlz1EGufm97G9IWRRQIFW65aoutHMoUQbpGiz57J2hwTY6gMGMV oHx+zM/TK6/H5drghk7PeeDyEt3fogNmdoFaHvfZ+RyNepkL36bVEOhji4cRDT00P2/B/wYBrnqOl KxVX3V6Od7UeBGYuW2QGYpIQaoJrMWS+/tu+XPEcaYwmCorsRQfEgBnHGhXW43mmnvNKf2T+YVxpq yx8Qtv3eplPkNc2Eer7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruged-00000009Gt1-0q18; Wed, 10 Apr 2024 22:42:55 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rugeZ-00000009GrH-3qpn for linux-mtd@lists.infradead.org; Wed, 10 Apr 2024 22:42:53 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-346b96f1483so21618f8f.1 for ; Wed, 10 Apr 2024 15:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mind.be; s=google; t=1712788967; x=1713393767; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PsT7sY0T3CGhWKIB6yVdHnCqmVwHF3DtjfPjZOhXj7w=; b=gSv368RMNlK8Hcdd0h+f5hHmir9ZVt+pqTJ0uRCgbVWfXqUyTUngffVbM22Z01NwtV ju8P7gHg+fc2h8XtR8hKlUJJWMGRjAJV+sYg9yFzxiwRUDZG78d81xoB1GZS9B4F8Rfa UyR3B9onEqOZkq0LLpTra0DOVlZ7IxgTuwSgBvarLjXDr2AKH7+1W9Synz/8/3hIEgu4 6JZpvbBJxhQeHqsVw3g4WxsIjC1LOJdMdN7Ikwvf6qAksJ1ujZNO+WUl5FYlKK818DOb Uja1+CTFtSw49JNmqX37RwDKJZidSBf1irDRpahsOihKfOPHc4goo3lmeElMj9Wkphyg 8wfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712788967; x=1713393767; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PsT7sY0T3CGhWKIB6yVdHnCqmVwHF3DtjfPjZOhXj7w=; b=Cud5qvh5aIS9hwmtQSEptH0k1A7aPnlYhiV6Y49LCFEhAv60YqkTlrY9Cis6dNT6ud QKvPTG91tKNv3NGgPh6STfD2pmVCn31cmsZEzchm9a4CzWXGNtS96+YLmDaqPwy9raA+ hWkFc/OSDqsEkX1QYZs1e+AkOUrPMgQys6PUHGuCoPb2cGkb1Rgz+ZFEmStJMRJiJtrr 4n2crh7RRVjrSG4TJtTzbgQV4rFLSZMbod0/BKomBCx6347saQZRjQGg4QgHjkpKB8Nl qHg8Sv0CBT6PEFlev5YE8cB9OdW68ridAkLiJpKGfQZDe5jjqki6cno7cuNuSS8IrbL7 FAcg== X-Gm-Message-State: AOJu0YwcmfglAuBxPyFYbBWX6GD+o0996hw3dJnIJ47iWQ44pxZewdcB d+aHmvnviQAOMqdGIHmjVpMJMWQZh4CthAoIITefL1zzFHXTEfuNG1bLw4vt9iA/Si1jqh8Bs7I cu3c= X-Google-Smtp-Source: AGHT+IEnK4dxZlG5Mvzhp6CVQrn9KFSAP9OG2nva4L6gG0qw+d2isMcacaCfZBgHocYUqkNCXHIEFA== X-Received: by 2002:adf:b60b:0:b0:343:4170:f3f1 with SMTP id f11-20020adfb60b000000b003434170f3f1mr775571wre.33.1712788967412; Wed, 10 Apr 2024 15:42:47 -0700 (PDT) Received: from cephalopod.i.decadent.org.uk (213.219.156.63.adsl.dyn.edpnet.net. [213.219.156.63]) by smtp.gmail.com with ESMTPSA id c10-20020a5d4cca000000b0034698307cf8sm271337wrt.15.2024.04.10.15.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 15:42:46 -0700 (PDT) From: Ben Hutchings To: linux-mtd@lists.infradead.org Cc: Ben Hutchings Subject: [PATCH 0/2] mtd: ubi: Fix some initialisation failure cases Date: Thu, 11 Apr 2024 00:42:40 +0200 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_154252_273171_E50262ED X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.1 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: ubi currently fails to initialise if debugfs is enabled at build time but disabled at boot time (CONFIG_DEBUG_FS is enabled and debugfs=off is set on the kernel command line). Errors from debugfs shou [...] Content analysis details: (0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:42c listed in] [list.dnswl.org] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org ubi currently fails to initialise if debugfs is enabled at build time but disabled at boot time (CONFIG_DEBUG_FS is enabled and debugfs=off is set on the kernel command line). Errors from debugfs should always be ignored but this wasn't done everywhere. While fixing this I also noticed that a recent change to ubi removed some cleanup from the ubi_init() failure path that I think is still needed. This series should fix both problems. Ben. Ben Hutchings (2): mtd: ubi: Restore missing cleanup on ubi_init() failure path mtd: ubi: Ignore all debugfs initialisation failures drivers/mtd/ubi/build.c | 15 ++++++--------- drivers/mtd/ubi/debug.c | 33 +++++++-------------------------- drivers/mtd/ubi/debug.h | 4 ++-- 3 files changed, 15 insertions(+), 37 deletions(-)