mbox series

[v3,00/12] Introduce generic ONFI support

Message ID MN2PR08MB59514E77250C3F0DA76D4801B8140@MN2PR08MB5951.namprd08.prod.outlook.com
Headers show
Series Introduce generic ONFI support | expand

Message

Shivamurthy Shastri (sshivamurthy) June 3, 2019, 12:43 p.m. UTC 
Current support to ONFI parameter page is only for raw NAND, this patch
series turn ONFI support into generic. So that, other NAND devices like
SPI NAND can use this.

There are five parts in this series.
1. Prepare for turning ONFI into generic
2. Turn ONFI into generic, which can be used by SPI NANDs later
3. Turn SPI NAND core to use parameter page
4. Redesign Micron SPI NAND driver implementation
5. Support for new Micron SPI NAND devices

Changes in V3
-------------

* Rebased to nand/next
* Split the patches as per suggestion
* Addressed the comments
* Some fixes which I missed in last version

Shivamurthy Shastri (12):
  mtd: rawnand: turn nand_onfi_detect to use nand_device
  mtd: rawnand: move ONFI related functions to nand.h
  mtd: rawnand: move sanitize_strings to nand_onfi.c
  mtd: rawnand: introduce struct onfi_helper
  mtd: rawnand: turn ONFI support to generic
  mtd: nand: Move ONFI code into nand/ directory
  mtd: spinand: turn SPI NAND to support parameter page detection
  mtd: spinand: add parameter page fixup function
  mtd: spinand: micron: prepare for generalizing driver
  mtd: spinand: micron: Turn driver implementation generic
  mtd: spinand: micron: Fix read failure in Micron M70A flashes
  mtd: spinand: micron: Enable micron flashes with multi-die

 drivers/mtd/nand/Makefile        |   2 +-
 drivers/mtd/nand/onfi.c          | 180 ++++++++++++++++++
 drivers/mtd/nand/raw/Makefile    |   1 -
 drivers/mtd/nand/raw/internals.h |   4 -
 drivers/mtd/nand/raw/nand_base.c | 236 +++++++++++++++++++++--
 drivers/mtd/nand/raw/nand_onfi.c | 312 -------------------------------
 drivers/mtd/nand/spi/core.c      | 111 ++++++++++-
 drivers/mtd/nand/spi/micron.c    | 107 ++++++++---
 include/linux/mtd/nand.h         |  30 +++
 include/linux/mtd/rawnand.h      |   5 +
 include/linux/mtd/spinand.h      |   6 +
 11 files changed, 628 insertions(+), 366 deletions(-)
 create mode 100644 drivers/mtd/nand/onfi.c
 delete mode 100644 drivers/mtd/nand/raw/nand_onfi.c

Comments

Miquel Raynal June 27, 2019, 2:49 p.m. UTC | #1 
Hi Shivamurthy,

"Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com> wrote on
Mon, 3 Jun 2019 12:43:20 +0000:

> Current support to ONFI parameter page is only for raw NAND, this patch
> series turn ONFI support into generic. So that, other NAND devices like
> SPI NAND can use this.
> 
> There are five parts in this series.
> 1. Prepare for turning ONFI into generic
> 2. Turn ONFI into generic, which can be used by SPI NANDs later
> 3. Turn SPI NAND core to use parameter page
> 4. Redesign Micron SPI NAND driver implementation
> 5. Support for new Micron SPI NAND devices
> 

I am very sorry for the delay, I will have a deep look at your series
very soon.

> Changes in V3
> -------------
> 
> * Rebased to nand/next
> * Split the patches as per suggestion
> * Addressed the comments
> * Some fixes which I missed in last version

As a simple note, please mind that "addressed the comments" is way too
generic. "Some fixes" as well. I have plenty of series to follow, you
need to do very careful when you write this changelog, it is important
for me.

Also, for the next series you submit, please use a threaded logic where
all patches are answers to the cover letter (this way it appears as a
thread and it is considered as one series by patchwork.

Thanks,
Miquèl