mbox series

[v6,00/15] Some bugfixs for ubi/ubifs

Message ID 20211227032246.2886878-1-chengzhihao1@huawei.com
Headers show
Series Some bugfixs for ubi/ubifs | expand

Message

Zhihao Cheng Dec. 27, 2021, 3:22 a.m. UTC 
v1->v2:
  1. Add new fix for ubifs, "ubifs: Fix to add refcount once page is set
  private"
  2. Update "ubifs: Rename whiteout atomically":
     1) Move inode mode in create_whiteout()
     2) Don't check O_SYNC for whiteout, because it inherits from the old_dir
     3) Remove useless 'synced_i_size ' assignment for whiteout, because
	it's always be zero.
     4) Remove unused variable 'ui' in create_whiteout()
  3. Update "ubifs: setflags: Make dirtied_ino_d 8 bytes aligned":
     1) Align dirtied_ino_d with 8 bytes.

v2->v3:
  1. Update "ubifs: Rename whiteout atomically":
     1) Fix misspelling 'have already check the old dir inode' ->
        'have already checked the old dir inode'
     2) Fix misspelling "Whiteout don't have non-zero size" ->
        "Whiteout  have non-zero size"
  2. Update "ubifs: Fix to add refcount once page is set private"
     1) Fix commit message to explain the root cause.
  3. Update "ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when
     fm->used_blocks>=2"
     1) Add fastmap used pebs into 'ai' in for-loop, rather than in
        two-steps(Add pebs [pnum<UBI_FM_MAX_START] then add pebs
	[pnum>=UBI_FM_MAX_START] into 'ai').

v3->v4:
  1. Update "ubifs: Add missing iput if do_tmpfile() failed in rename whiteout":
     1) Move whiteout cleanup into do_tmpfile() according to Sascha's advice
  2. Add new fix for ubifs, "ubifs: ubifs_writepage: Mark page dirty after
     writing inode failed"

v4->v5:
  1. Add new fix for ubifs, "ubifs: ubifs_releasepage: Remove ubifs_assert(0)
     to valid this process"

v5->v6:
  1. Add new fix for ubi: "ubi: fastmap: Fix high cpu usage of ubi_bgt by
     making sure wl_pool not empty"

Zhihao Cheng (15):
  ubifs: rename_whiteout: Fix double free for whiteout_ui->data
  ubifs: Fix deadlock in concurrent rename whiteout and inode writeback
  ubifs: Fix wrong number of inodes locked by ui_mutex in ubifs_inode
    comment
  ubifs: Add missing iput if do_tmpfile() failed in rename whiteout
  ubifs: Rename whiteout atomically
  ubifs: Fix 'ui->dirty' race between do_tmpfile() and writeback work
  ubifs: Rectify space amount budget for mkdir/tmpfile operations
  ubifs: setflags: Make dirtied_ino_d 8 bytes aligned
  ubifs: Fix read out-of-bounds in ubifs_wbuf_write_nolock()
  ubifs: Fix to add refcount once page is set private
  ubi: fastmap: Return error code if memory allocation fails in
    add_aeb()
  ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when
    fm->used_blocks>=2
  ubifs: ubifs_writepage: Mark page dirty after writing inode failed
  ubifs: ubifs_releasepage: Remove ubifs_assert(0) to valid this process
  ubi: fastmap: Fix high cpu usage of ubi_bgt by making sure wl_pool not
    empty

 drivers/mtd/ubi/fastmap-wl.c |   5 +-
 drivers/mtd/ubi/fastmap.c    |  63 ++++------
 drivers/mtd/ubi/wl.h         |  11 +-
 fs/ubifs/dir.c               | 235 +++++++++++++++++++++--------------
 fs/ubifs/file.c              |  45 ++++---
 fs/ubifs/io.c                |  34 ++++-
 fs/ubifs/ioctl.c             |   2 +-
 fs/ubifs/journal.c           |  52 ++++++--
 fs/ubifs/ubifs.h             |   2 +-
 9 files changed, 284 insertions(+), 165 deletions(-)

Comments

Richard Weinberger Dec. 27, 2021, 10:13 a.m. UTC | #1 
----- Ursprüngliche Mail -----
> Von: "chengzhihao1" <chengzhihao1@huawei.com>
> An: "richard" <richard@nod.at>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "Vignesh Raghavendra" <vigneshr@ti.com>,
> "mcoquelin stm32" <mcoquelin.stm32@gmail.com>, "kirill shutemov" <kirill.shutemov@linux.intel.com>, "Sascha Hauer"
> <s.hauer@pengutronix.de>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>
> Gesendet: Montag, 27. Dezember 2021 04:22:31
> Betreff: [PATCH v6 00/15] Some bugfixs for ubi/ubifs

> v1->v2:
>  1. Add new fix for ubifs, "ubifs: Fix to add refcount once page is set
>  private"
>  2. Update "ubifs: Rename whiteout atomically":
>     1) Move inode mode in create_whiteout()
>     2) Don't check O_SYNC for whiteout, because it inherits from the old_dir
>     3) Remove useless 'synced_i_size ' assignment for whiteout, because
>	it's always be zero.
>     4) Remove unused variable 'ui' in create_whiteout()
>  3. Update "ubifs: setflags: Make dirtied_ino_d 8 bytes aligned":
>     1) Align dirtied_ino_d with 8 bytes.
> 
> v2->v3:
>  1. Update "ubifs: Rename whiteout atomically":
>     1) Fix misspelling 'have already check the old dir inode' ->
>        'have already checked the old dir inode'
>     2) Fix misspelling "Whiteout don't have non-zero size" ->
>        "Whiteout  have non-zero size"
>  2. Update "ubifs: Fix to add refcount once page is set private"
>     1) Fix commit message to explain the root cause.
>  3. Update "ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when
>     fm->used_blocks>=2"
>     1) Add fastmap used pebs into 'ai' in for-loop, rather than in
>        two-steps(Add pebs [pnum<UBI_FM_MAX_START] then add pebs
>	[pnum>=UBI_FM_MAX_START] into 'ai').
> 
> v3->v4:
>  1. Update "ubifs: Add missing iput if do_tmpfile() failed in rename whiteout":
>     1) Move whiteout cleanup into do_tmpfile() according to Sascha's advice
>  2. Add new fix for ubifs, "ubifs: ubifs_writepage: Mark page dirty after
>     writing inode failed"
> 
> v4->v5:
>  1. Add new fix for ubifs, "ubifs: ubifs_releasepage: Remove ubifs_assert(0)
>     to valid this process"
> 
> v5->v6:
>  1. Add new fix for ubi: "ubi: fastmap: Fix high cpu usage of ubi_bgt by
>     making sure wl_pool not empty"
> 
> Zhihao Cheng (15):
>  ubifs: rename_whiteout: Fix double free for whiteout_ui->data
>  ubifs: Fix deadlock in concurrent rename whiteout and inode writeback
>  ubifs: Fix wrong number of inodes locked by ui_mutex in ubifs_inode
>    comment
>  ubifs: Add missing iput if do_tmpfile() failed in rename whiteout
>  ubifs: Rename whiteout atomically
>  ubifs: Fix 'ui->dirty' race between do_tmpfile() and writeback work
>  ubifs: Rectify space amount budget for mkdir/tmpfile operations
>  ubifs: setflags: Make dirtied_ino_d 8 bytes aligned
>  ubifs: Fix read out-of-bounds in ubifs_wbuf_write_nolock()
>  ubifs: Fix to add refcount once page is set private
>  ubi: fastmap: Return error code if memory allocation fails in
>    add_aeb()
>  ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when
>    fm->used_blocks>=2
>  ubifs: ubifs_writepage: Mark page dirty after writing inode failed
>  ubifs: ubifs_releasepage: Remove ubifs_assert(0) to valid this process
>  ubi: fastmap: Fix high cpu usage of ubi_bgt by making sure wl_pool not
>    empty

Thanks a lot for all this fixes! I will start reviewing/picking them an
as soon the series is stable.
So please don't resend everything if you only add a new patch.

Thanks,
//richard
Zhihao Cheng Dec. 27, 2021, 12:19 p.m. UTC | #2 
在 2021/12/27 18:13, Richard Weinberger 写道:

> Thanks a lot for all this fixes! I will start reviewing/picking them an
> as soon the series is stable.
> So please don't resend everything if you only add a new patch.
OK. New patches(If I find new bugs) will be sent indepently. v6 series 
is closed.
Richard Weinberger Dec. 27, 2021, 1 p.m. UTC | #3 
----- Ursprüngliche Mail -----
> Von: "chengzhihao1" <chengzhihao1@huawei.com>
>> Thanks a lot for all this fixes! I will start reviewing/picking them an
>> as soon the series is stable.
>> So please don't resend everything if you only add a new patch.
> OK. New patches(If I find new bugs) will be sent indepently. v6 series
> is closed.

Thanks! Your fixes are most appreciated!

Thanks,
//richard