mbox series

[0/2] mkfs.ubifs: some error handling fixes

Message ID 20191110144442.26680-1-david.oberhollenzer@sigma-star.at
Headers show
Series mkfs.ubifs: some error handling fixes | expand


David Oberhollenzer Nov. 10, 2019, 2:44 p.m. UTC

poking around the mkfs.ubifs source, I discovered two cases of what I
suspect to be error cases that got ignored instead of propperly handled.

The first is probably the more delicate one where the return value of
gen_essiv_salt is never checked in the fscrypt code.

The second one concerns pre-populating the ubifs image, where a readdir
loop is aborted if readdir fails, but the error status is never reported
back and the code simply marches on.

Please tell me if my fixes break something elsewhere or my assumptions
about the intended behaviour are flawed. Otherwise I will merge this some
time next week.