mbox series

[v3,0/4] mtd: Preparation patches for the SPI NAND framework

Message ID 20171215123954.30017-1-boris.brezillon@free-electrons.com
Headers show
Series mtd: Preparation patches for the SPI NAND framework | expand

Message

Boris Brezillon Dec. 15, 2017, 12:39 p.m. UTC 
Hello,

Here is a set of patches to prepare the introduction of the generic
NAND and SPI frameworks.

The last 2 patches have already been submitted here [1], and the first
two are new, and should also help simplify other drivers/frameworks
in providing generic code for already existing logic.

If you want to see the overall picture of the SPI NAND framework you can
have a look at this branch [2].

Regards,

Boris

[1]https://patchwork.ozlabs.org/patch/780477/
[2]https://github.com/bbrezillon/linux-0day/commits/nand/spi-nand-squashed

Boris Brezillon (4):
  mtd: Do not allow MTD devices with inconsistent erase properties
  mtd: Add an helper to make erase request aligned on ->erasesize
  mtd: Stop directly calling master ->_xxx() hooks from mtdpart code
  mtd: Fallback to ->_read/write_oob() when ->_read/write() is missing

 drivers/mtd/devices/docg3.c        |  65 -----------------
 drivers/mtd/mtdcore.c              |  36 +++++++++-
 drivers/mtd/mtdpart.c              | 141 ++++++++++++++-----------------------
 drivers/mtd/nand/nand_base.c       |  56 ---------------
 drivers/mtd/onenand/onenand_base.c |  63 -----------------
 include/linux/mtd/mtd.h            |  28 ++++++++
 6 files changed, 115 insertions(+), 274 deletions(-)

Comments

Miquel Raynal Dec. 17, 2017, 9:39 p.m. UTC | #1 
Hello Boris,

On Fri, 15 Dec 2017 13:39:50 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> Hello,
> 
> Here is a set of patches to prepare the introduction of the generic
> NAND and SPI frameworks.
> 
> The last 2 patches have already been submitted here [1], and the first
> two are new, and should also help simplify other drivers/frameworks
> in providing generic code for already existing logic.
> 
> If you want to see the overall picture of the SPI NAND framework you
> can have a look at this branch [2].
> 
> Regards,
> 
> Boris
> 
> [1]https://patchwork.ozlabs.org/patch/780477/
> [2]https://github.com/bbrezillon/linux-0day/commits/nand/spi-nand-squashed
> 
> Boris Brezillon (4):
>   mtd: Do not allow MTD devices with inconsistent erase properties
>   mtd: Add an helper to make erase request aligned on ->erasesize
>   mtd: Stop directly calling master ->_xxx() hooks from mtdpart code
>   mtd: Fallback to ->_read/write_oob() when ->_read/write() is missing

I did not spot anything strange on the four patches :) so for the
series:

Reviewed-by: Miquel Raynal <miquel.raynal@free-electrons.com>

Thank you,
Miquèl

> 
>  drivers/mtd/devices/docg3.c        |  65 -----------------
>  drivers/mtd/mtdcore.c              |  36 +++++++++-
>  drivers/mtd/mtdpart.c              | 141
> ++++++++++++++-----------------------
> drivers/mtd/nand/nand_base.c       |  56 ---------------
> drivers/mtd/onenand/onenand_base.c |  63 -----------------
> include/linux/mtd/mtd.h            |  28 ++++++++ 6 files changed,
> 115 insertions(+), 274 deletions(-)
>
Boris Brezillon Jan. 6, 2018, 8:43 p.m. UTC | #2 
On Fri, 15 Dec 2017 13:39:50 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> Hello,
> 
> Here is a set of patches to prepare the introduction of the generic
> NAND and SPI frameworks.
> 
> The last 2 patches have already been submitted here [1], and the first
> two are new, and should also help simplify other drivers/frameworks
> in providing generic code for already existing logic.
> 
> If you want to see the overall picture of the SPI NAND framework you can
> have a look at this branch [2].
> 
> Regards,
> 
> Boris
> 
> [1]https://patchwork.ozlabs.org/patch/780477/
> [2]https://github.com/bbrezillon/linux-0day/commits/nand/spi-nand-squashed
> 
> Boris Brezillon (4):
>   mtd: Do not allow MTD devices with inconsistent erase properties
>   mtd: Add an helper to make erase request aligned on ->erasesize
>   mtd: Stop directly calling master ->_xxx() hooks from mtdpart code
>   mtd: Fallback to ->_read/write_oob() when ->_read/write() is missing

Applied the whole series. I'm preparing a patch to remove unneeded
checks done in part_read/write_oob() (as suggested by Peter).

> 
>  drivers/mtd/devices/docg3.c        |  65 -----------------
>  drivers/mtd/mtdcore.c              |  36 +++++++++-
>  drivers/mtd/mtdpart.c              | 141 ++++++++++++++-----------------------
>  drivers/mtd/nand/nand_base.c       |  56 ---------------
>  drivers/mtd/onenand/onenand_base.c |  63 -----------------
>  include/linux/mtd/mtd.h            |  28 ++++++++
>  6 files changed, 115 insertions(+), 274 deletions(-)
>