| Message ID | 1583220084-10890-1-git-send-email-masonccyang@mxic.com.tw |
|---|---|
| Headers | show |
| Series | mtd: rawnand: Add support Macronix Block Portection & Deep Power Down mode | expand |
Hi Mason, Mason Yang <masonccyang@mxic.com.tw> wrote on Tue, 3 Mar 2020 15:21:20 +0800: > Hi, > > Changelog > > v3: > patch nand_lock_area/nand_unlock_area. > fixed kbuidtest robot warnings and reviewer's comments. I know it is painful for the contributor but I really need more details in the changelog. This is something I care about because I can speed-up my reviews when I know what I already acked or not. "fixing reviewer's comments" is way too vague, I have absolutely no idea of what I told you last time :) So please, for the next iterations, be more verbose in these changelogs! (that's fine for this one, I'll check myself). Cheers, Miquèl
Hi Miquel, > > Mason Yang <masonccyang@mxic.com.tw> wrote on Tue, 3 Mar 2020 15:21:20 > +0800: > > > Hi, > > > > Changelog > > > > v3: > > patch nand_lock_area/nand_unlock_area. > > fixed kbuidtest robot warnings and reviewer's comments. > > I know it is painful for the contributor but I really need more details > in the changelog. This is something I care about because I can speed-up okay, more changelog as 1. Patched the Kdoc for both lock_area/unlock_area and _suspend/_resume 2. Created a helper to read default protected value (after device power on) for protection function detection. 3. patched the prefix for Macronix deep power down command, 0xB9 4. Patched the description of mxic_nand_resume() and add a small sleeping delay. 5. Created a helper for deep power down device part number detection. > my reviews when I know what I already acked or not. "fixing reviewer's > comments" is way too vague, I have absolutely no idea of what I told > you last time :) So please, for the next iterations, be more verbose in > these changelogs! (that's fine for this one, I'll check myself). > > Cheers, > Miquèl thanks for your time and review. Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
Hi Mason, masonccyang@mxic.com.tw wrote on Tue, 10 Mar 2020 10:30:09 +0800: > Hi Miquel, > > > > > Mason Yang <masonccyang@mxic.com.tw> wrote on Tue, 3 Mar 2020 15:21:20 > > +0800: > > > > > Hi, > > > > > > Changelog > > > > > > v3: > > > patch nand_lock_area/nand_unlock_area. > > > fixed kbuidtest robot warnings and reviewer's comments. > > > > I know it is painful for the contributor but I really need more details > > in the changelog. This is something I care about because I can speed-up > > okay, more changelog as > > 1. Patched the Kdoc for both lock_area/unlock_area and _suspend/_resume > 2. Created a helper to read default protected value (after device power > on) > for protection function detection. > 3. patched the prefix for Macronix deep power down command, 0xB9 > 4. Patched the description of mxic_nand_resume() and add a small sleeping > delay. > 5. Created a helper for deep power down device part number detection. > Way more descriptive! Thanks a lot. Cheers, Miquèl
Hi, Changelog v3: patch nand_lock_area/nand_unlock_area. fixed kbuidtest robot warnings and reviewer's comments. v2: Patch nand_lock() & nand_unlock() for MTD->_lock/_unlock default call-back function replacement. Patch nand_suspend() & nand_resume() with manufacturer specific operation. v1: Patch manufacturer post_init for MTD->_lock/_unlock & MTD->_suspend/_resume replacement. thanks for your time & review. Mason Mason Yang (4): mtd: rawnand: Add support manufacturer specific lock/unlock operation mtd: rawnand: Add support Macronix Block Protection function mtd: rawnand: Add support manufacturer specific suspend/resume operation mtd: rawnand: Add support Macronix deep power down mode drivers/mtd/nand/raw/nand_base.c | 47 +++++++++-- drivers/mtd/nand/raw/nand_macronix.c | 146 +++++++++++++++++++++++++++++++++++ include/linux/mtd/rawnand.h | 9 +++ 3 files changed, 197 insertions(+), 5 deletions(-)