| Message ID | 1545214186-16987-1-git-send-email-yogeshnarayan.gaur@nxp.com |
|---|---|
| Headers | show |
| Series | spi: add support for octal mode | expand |
Hi, On 19/12/18 3:41 PM, Yogesh Narayan Gaur wrote: > Add support for octal mode IO data transfer. > Micron flash, mt35xu512aba, supports octal mode data transfer and > NXP FlexSPI controller supports 8 data lines for data transfer (Rx/Tx). > > Patch series > * Add support for octal mode flags and parsing of same in spi driver. > * Add parsing logic for spi-mem framework and m25p80.c device file. > * Add opcodes for octal I/O commands in spi-nor framework, Read and Write proto for (1-1-8/1-8-8) mode. > Opcodes are added as per octal data IO commands required for mt35xu512aba [1] flash. > * Add mode bit required for octal mode in nxp-fspi driver [2]. > * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2]. > > Tested on LX2160ARDB target with nxp-fspi driver, below are > Read performance number of 1-1-1 and 1-1-8 read protocol. > > root@lxxx:~# cat /proc/mtd > dev: size erasesize name > mtd0: 04000000 00001000 "spi0.0" > mtd1: 04000000 00001000 "spi0.1" > root@lxxx:~# time mtd_debug read /dev/mtd0 0x0 0x1000000 0read > Copied 16777216 bytes from address 0x00000000 in flash to 0read > > real 0m2.792s > user 0m0.000s > sys 0m2.790s > root@lxxx:~# time mtd_debug read /dev/mtd1 0x0 0x1000000 0read > Copied 16777216 bytes from address 0x00000000 in flash to 0read > > real 0m0.441s > user 0m0.000s > sys 0m0.440s > root@ls1012ardb:~# > > > Flash device MTD0 configured in 1-1-1 protocol. > Flash device MTD1 configured in 1-1-8 protocol. > > [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=70384&state=* > [2] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=76402 > > Yogesh Gaur (7): > spi: add support for octal mode I/O data transfer > spi: spi-mem: add support for octal mode I/O data transfer These two patches are already merged and is now part of linux-next[1]. Its preferred to send patches based on top of latest linux-next so as to avoid resending patches that have already been picked up by the maintainer. [1] commit 6b03061f882de49b83ccf44beb3a12c920a2da1b Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> Date: Mon Dec 3 08:39:06 2018 +0000 spi: add support for octal mode I/O data transfer commit b12a084c8729ef423089bb9a5a143eed39cd94e7 Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> Date: Mon Dec 3 08:39:12 2018 +0000 spi: spi-mem: add support for octal mode I/O data transfer Regards Vignesh > mtd: spi-nor: add opcodes for octal Read/Write commands > mtd: spi-nor: add octal read flag for flash mt35xu512aba > mtd: m25p80: add support of octal mode I/O transfer > spi: nxp-fspi: add octal mode flag bit for octal support > arm64: dts: lx2160a: update fspi node > > Changes for v6: > - Correct S-o-b tag with full author name as 'Yogesh Narayan Gaur'. > - Rebase on top of v4.20-rc5. > Changes for v5: > - Modified string 'octo' as 'octal' in all patches. > Changes for v4: > - Rebase on top of v4.20-rc2. > - Modify octo entries enum value in spi.h. > Changes for v3: > - Add octo mode support in spi_setup(). > - Rename all patches with 'octal' string modified as 'octo'. > Changes for v2: > - Incorporated review comments of Boris and Vignesh. > > Yogesh Gaur (7): > spi: add support for octal mode I/O data transfer > spi: spi-mem: add support for octal mode I/O data transfer > mtd: spi-nor: add opcodes for octal Read/Write commands > mtd: spi-nor: add octal read flag for flash mt35xu512aba > mtd: m25p80: add support of octal mode I/O transfer > spi: nxp-fspi: add octal mode flag bit for octal support > arm64: dts: lx2160a: update fspi node > > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++ > drivers/mtd/devices/m25p80.c | 9 ++++++++- > drivers/mtd/spi-nor/spi-nor.c | 19 ++++++++++++++++--- > drivers/spi/spi-mem.c | 9 ++++++++- > drivers/spi/spi-nxp-fspi.c | 4 ++-- > drivers/spi/spi.c | 12 ++++++++++-- > include/linux/mtd/spi-nor.h | 16 ++++++++++++---- > include/linux/spi/spi.h | 4 +++- > 8 files changed, 63 insertions(+), 14 deletions(-) >
Hi Vignesh, > -----Original Message----- > From: Vignesh R [mailto:vigneshr@ti.com] > Sent: Wednesday, December 19, 2018 6:14 PM > To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>; linux- > mtd@lists.infradead.org; boris.brezillon@bootlin.com; broonie@kernel.org; > marek.vasut@gmail.com; linux-spi@vger.kernel.org; > devicetree@vger.kernel.org > Cc: tudor.ambarus@microchip.com; robh@kernel.org; mark.rutland@arm.com; > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org; > computersforpeace@gmail.com; frieder.schrempf@exceet.de; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH v6 0/7] spi: add support for octal mode > > Hi, > > On 19/12/18 3:41 PM, Yogesh Narayan Gaur wrote: > > Add support for octal mode IO data transfer. > > Micron flash, mt35xu512aba, supports octal mode data transfer and NXP > > FlexSPI controller supports 8 data lines for data transfer (Rx/Tx). > > > > Patch series > > * Add support for octal mode flags and parsing of same in spi driver. > > * Add parsing logic for spi-mem framework and m25p80.c device file. > > * Add opcodes for octal I/O commands in spi-nor framework, Read and Write > proto for (1-1-8/1-8-8) mode. > > Opcodes are added as per octal data IO commands required for > mt35xu512aba [1] flash. > > * Add mode bit required for octal mode in nxp-fspi driver [2]. > > * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2]. > > > > Tested on LX2160ARDB target with nxp-fspi driver, below are Read > > performance number of 1-1-1 and 1-1-8 read protocol. > > > > root@lxxx:~# cat /proc/mtd > > dev: size erasesize name > > mtd0: 04000000 00001000 "spi0.0" > > mtd1: 04000000 00001000 "spi0.1" > > root@lxxx:~# time mtd_debug read /dev/mtd0 0x0 0x1000000 0read > > Copied 16777216 bytes from address 0x00000000 in flash to 0read > > > > real 0m2.792s > > user 0m0.000s > > sys 0m2.790s > > root@lxxx:~# time mtd_debug read /dev/mtd1 0x0 0x1000000 0read > > Copied 16777216 bytes from address 0x00000000 in flash to 0read > > > > real 0m0.441s > > user 0m0.000s > > sys 0m0.440s > > root@ls1012ardb:~# > > > > > > Flash device MTD0 configured in 1-1-1 protocol. > > Flash device MTD1 configured in 1-1-8 protocol. > > > > [1] > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat > > chwork.ozlabs.org%2Fproject%2Flinux- > mtd%2Flist%2F%3Fseries%3D70384%26s > > > tate%3D*&data=02%7C01%7Cyogeshnarayan.gaur%40nxp.com%7Cac5c9 > ca4ad0 > > > 84f10762208d665af9130%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > %7C636 > > > 808202064181032&sdata=LCjo%2B%2FhIpEYygsLHMFzb65ZtXjsDdhEAVV4 > %2BjQ > > iyUtI%3D&reserved=0 [2] > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat > > chwork.ozlabs.org%2Fproject%2Flinux- > mtd%2Flist%2F%3Fseries%3D76402& > > ;data=02%7C01%7Cyogeshnarayan.gaur%40nxp.com%7Cac5c9ca4ad084f107 > 62208d > > > 665af9130%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636808202 > 064181 > > > 032&sdata=A9hAX4oTyJPzc4J3y3PqwNagWEqvpGolf8RE9RyYV28%3D&am > p;reser > > ved=0 > > > > Yogesh Gaur (7): > > spi: add support for octal mode I/O data transfer > > spi: spi-mem: add support for octal mode I/O data transfer > > > These two patches are already merged and is now part of linux-next[1]. > Its preferred to send patches based on top of latest linux-next so as to avoid > resending patches that have already been picked up by the maintainer. > > [1] > commit 6b03061f882de49b83ccf44beb3a12c920a2da1b > Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> > Date: Mon Dec 3 08:39:06 2018 +0000 > > spi: add support for octal mode I/O data transfer > > commit b12a084c8729ef423089bb9a5a143eed39cd94e7 > Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> > Date: Mon Dec 3 08:39:12 2018 +0000 > > spi: spi-mem: add support for octal mode I/O data transfer > > I have checked on repo "git://git.infradead.org/linux-mtd.git" on branch "spi-nor/next" and in that kernel version is 4.20.-rc5. In this repo above 2 patches are not present and hence has send the patches by moving to top of this repo. Can you please let me know the repo of linux-next and branch to use. -- Regards Yogesh Gaur > Regards > Vignesh > > > mtd: spi-nor: add opcodes for octal Read/Write commands > > mtd: spi-nor: add octal read flag for flash mt35xu512aba > > mtd: m25p80: add support of octal mode I/O transfer > > spi: nxp-fspi: add octal mode flag bit for octal support > > arm64: dts: lx2160a: update fspi node > > > > Changes for v6: > > - Correct S-o-b tag with full author name as 'Yogesh Narayan Gaur'. > > - Rebase on top of v4.20-rc5. > > Changes for v5: > > - Modified string 'octo' as 'octal' in all patches. > > Changes for v4: > > - Rebase on top of v4.20-rc2. > > - Modify octo entries enum value in spi.h. > > Changes for v3: > > - Add octo mode support in spi_setup(). > > - Rename all patches with 'octal' string modified as 'octo'. > > Changes for v2: > > - Incorporated review comments of Boris and Vignesh. > > > > Yogesh Gaur (7): > > spi: add support for octal mode I/O data transfer > > spi: spi-mem: add support for octal mode I/O data transfer > > mtd: spi-nor: add opcodes for octal Read/Write commands > > mtd: spi-nor: add octal read flag for flash mt35xu512aba > > mtd: m25p80: add support of octal mode I/O transfer > > spi: nxp-fspi: add octal mode flag bit for octal support > > arm64: dts: lx2160a: update fspi node > > > > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++ > > drivers/mtd/devices/m25p80.c | 9 ++++++++- > > drivers/mtd/spi-nor/spi-nor.c | 19 ++++++++++++++++--- > > drivers/spi/spi-mem.c | 9 ++++++++- > > drivers/spi/spi-nxp-fspi.c | 4 ++-- > > drivers/spi/spi.c | 12 ++++++++++-- > > include/linux/mtd/spi-nor.h | 16 ++++++++++++---- > > include/linux/spi/spi.h | 4 +++- > > 8 files changed, 63 insertions(+), 14 deletions(-) > > > > -- > Regards > Vignesh
Hi, On 20/12/18 11:02 AM, Yogesh Narayan Gaur wrote: [...] >>> Yogesh Gaur (7): >>> spi: add support for octal mode I/O data transfer >>> spi: spi-mem: add support for octal mode I/O data transfer >> >> >> These two patches are already merged and is now part of linux-next[1]. >> Its preferred to send patches based on top of latest linux-next so as to avoid >> resending patches that have already been picked up by the maintainer. >> >> [1] >> commit 6b03061f882de49b83ccf44beb3a12c920a2da1b >> Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> >> Date: Mon Dec 3 08:39:06 2018 +0000 >> >> spi: add support for octal mode I/O data transfer >> >> commit b12a084c8729ef423089bb9a5a143eed39cd94e7 >> Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> >> Date: Mon Dec 3 08:39:12 2018 +0000 >> >> spi: spi-mem: add support for octal mode I/O data transfer >> >> > I have checked on repo "git://git.infradead.org/linux-mtd.git" on branch "spi-nor/next" and in that kernel version is 4.20.-rc5. > In this repo above 2 patches are not present and hence has send the patches by moving to top of this repo. > Those patches are applied to spi tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/log/?h=for-next > Can you please let me know the repo of linux-next and branch to use. > The linux-next tree is the holding area for patches aimed at the next kernel merge window. This tree includes spi-nor/next as part of mtd/next as well as many other subsystem specific -next trees: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git branch: master Regards Vignesh > -- > Regards > Yogesh Gaur > >> Regards >> Vignesh >> >>> mtd: spi-nor: add opcodes for octal Read/Write commands >>> mtd: spi-nor: add octal read flag for flash mt35xu512aba >>> mtd: m25p80: add support of octal mode I/O transfer >>> spi: nxp-fspi: add octal mode flag bit for octal support >>> arm64: dts: lx2160a: update fspi node >>> >>> Changes for v6: >>> - Correct S-o-b tag with full author name as 'Yogesh Narayan Gaur'. >>> - Rebase on top of v4.20-rc5. >>> Changes for v5: >>> - Modified string 'octo' as 'octal' in all patches. >>> Changes for v4: >>> - Rebase on top of v4.20-rc2. >>> - Modify octo entries enum value in spi.h. >>> Changes for v3: >>> - Add octo mode support in spi_setup(). >>> - Rename all patches with 'octal' string modified as 'octo'. >>> Changes for v2: >>> - Incorporated review comments of Boris and Vignesh. >>> >>> Yogesh Gaur (7): >>> spi: add support for octal mode I/O data transfer >>> spi: spi-mem: add support for octal mode I/O data transfer >>> mtd: spi-nor: add opcodes for octal Read/Write commands >>> mtd: spi-nor: add octal read flag for flash mt35xu512aba >>> mtd: m25p80: add support of octal mode I/O transfer >>> spi: nxp-fspi: add octal mode flag bit for octal support >>> arm64: dts: lx2160a: update fspi node >>> >>> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++ >>> drivers/mtd/devices/m25p80.c | 9 ++++++++- >>> drivers/mtd/spi-nor/spi-nor.c | 19 ++++++++++++++++--- >>> drivers/spi/spi-mem.c | 9 ++++++++- >>> drivers/spi/spi-nxp-fspi.c | 4 ++-- >>> drivers/spi/spi.c | 12 ++++++++++-- >>> include/linux/mtd/spi-nor.h | 16 ++++++++++++---- >>> include/linux/spi/spi.h | 4 +++- >>> 8 files changed, 63 insertions(+), 14 deletions(-) >>> >> >> -- >> Regards >> Vignesh
Hi All, > -----Original Message----- > From: Vignesh R [mailto:vigneshr@ti.com] > Sent: Thursday, December 20, 2018 12:03 PM > To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>; linux- > mtd@lists.infradead.org; boris.brezillon@bootlin.com; broonie@kernel.org; > marek.vasut@gmail.com; linux-spi@vger.kernel.org; > devicetree@vger.kernel.org > Cc: tudor.ambarus@microchip.com; robh@kernel.org; mark.rutland@arm.com; > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org; > computersforpeace@gmail.com; frieder.schrempf@exceet.de; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH v6 0/7] spi: add support for octal mode > > Hi, > > On 20/12/18 11:02 AM, Yogesh Narayan Gaur wrote: > [...] > >>> Yogesh Gaur (7): > >>> spi: add support for octal mode I/O data transfer > >>> spi: spi-mem: add support for octal mode I/O data transfer > >> > >> > >> These two patches are already merged and is now part of linux-next[1]. > >> Its preferred to send patches based on top of latest linux-next so as > >> to avoid resending patches that have already been picked up by the > maintainer. > >> > >> [1] > >> commit 6b03061f882de49b83ccf44beb3a12c920a2da1b > >> Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> > >> Date: Mon Dec 3 08:39:06 2018 +0000 > >> > >> spi: add support for octal mode I/O data transfer > >> > >> commit b12a084c8729ef423089bb9a5a143eed39cd94e7 > >> Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> > >> Date: Mon Dec 3 08:39:12 2018 +0000 > >> > >> spi: spi-mem: add support for octal mode I/O data transfer > >> > >> > > I have checked on repo "git://git.infradead.org/linux-mtd.git" on branch "spi- > nor/next" and in that kernel version is 4.20.-rc5. > > In this repo above 2 patches are not present and hence has send the patches > by moving to top of this repo. > > > > Those patches are applied to spi tree: > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker > nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbroonie%2Fspi.git%2Flog% > 2F%3Fh%3Dfor- > next&data=02%7C01%7Cyogeshnarayan.gaur%40nxp.com%7Cc24a66e695 > 7f4940e83708d66644f5bf%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > %7C636808843700180940&sdata=4IPwuRmJKv4qISAjD0W07OIA%2BWQpT > 3E97T%2BSbSOrSN8%3D&reserved=0 > > > Can you please let me know the repo of linux-next and branch to use. > > > > The linux-next tree is the holding area for patches aimed at the next kernel > merge window. This tree includes spi-nor/next as part of mtd/next as well as > many other subsystem specific -next trees: > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker > nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux- > next.git&data=02%7C01%7Cyogeshnarayan.gaur%40nxp.com%7Cc24a66e > 6957f4940e83708d66644f5bf%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% > 7C0%7C636808843700180940&sdata=VGMHZCjAgZfnSJeUHhkpgI0ygt9pvP > y9KJs5Pzn64D0%3D&reserved=0 branch: master > > Above repo "kernel/git/broonie/spi.git" and branch (for-next) are missing below 2 patches[1], which have been applied by Boris and present in repo "git://git.infradead.org/linux-mtd.git" on branch "spi-nor/next". commit a98086e00420ad92cfa961bcbb457fbe52ec28c9 Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> Date: Fri Oct 12 02:23:13 2018 +0000 mtd: spi-nor: add entry for mt35xu512aba flash Add entry for mt35xu512aba Micron NOR flash. This flash is having uniform sector erase size of 128KB, have support of FSR(flag status register), flash size is 64MB and supports 4-byte commands. Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> commit 0005aad094538e1c290b1cdb5b940e4a16f405b0 Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> Date: Fri Oct 12 02:23:08 2018 +0000 mtd: spi-nor: add macros related to MICRON flash Some MICRON related macros in spi-nor domain were ST. Rename entries related to STMicroelectronics under macro SNOR_MFR_ST. Added entry of MFR Id for Micron flashes, 0x002C. Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Octal mode support patch series has dependency over these patches. Should I send these two patches again or specifies them as dependency patches in the cover letter. -- Regards Yogesh Gaur [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=70384&state=* > Regards > Vignesh > > > -- > > Regards > > Yogesh Gaur > > > >> Regards > >> Vignesh > >> > >>> mtd: spi-nor: add opcodes for octal Read/Write commands > >>> mtd: spi-nor: add octal read flag for flash mt35xu512aba > >>> mtd: m25p80: add support of octal mode I/O transfer > >>> spi: nxp-fspi: add octal mode flag bit for octal support > >>> arm64: dts: lx2160a: update fspi node > >>> > >>> Changes for v6: > >>> - Correct S-o-b tag with full author name as 'Yogesh Narayan Gaur'. > >>> - Rebase on top of v4.20-rc5. > >>> Changes for v5: > >>> - Modified string 'octo' as 'octal' in all patches. > >>> Changes for v4: > >>> - Rebase on top of v4.20-rc2. > >>> - Modify octo entries enum value in spi.h. > >>> Changes for v3: > >>> - Add octo mode support in spi_setup(). > >>> - Rename all patches with 'octal' string modified as 'octo'. > >>> Changes for v2: > >>> - Incorporated review comments of Boris and Vignesh. > >>> > >>> Yogesh Gaur (7): > >>> spi: add support for octal mode I/O data transfer > >>> spi: spi-mem: add support for octal mode I/O data transfer > >>> mtd: spi-nor: add opcodes for octal Read/Write commands > >>> mtd: spi-nor: add octal read flag for flash mt35xu512aba > >>> mtd: m25p80: add support of octal mode I/O transfer > >>> spi: nxp-fspi: add octal mode flag bit for octal support > >>> arm64: dts: lx2160a: update fspi node > >>> > >>> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++ > >>> drivers/mtd/devices/m25p80.c | 9 ++++++++- > >>> drivers/mtd/spi-nor/spi-nor.c | 19 ++++++++++++++++--- > >>> drivers/spi/spi-mem.c | 9 ++++++++- > >>> drivers/spi/spi-nxp-fspi.c | 4 ++-- > >>> drivers/spi/spi.c | 12 ++++++++++-- > >>> include/linux/mtd/spi-nor.h | 16 ++++++++++++---- > >>> include/linux/spi/spi.h | 4 +++- > >>> 8 files changed, 63 insertions(+), 14 deletions(-) > >>> > >> > >> -- > >> Regards > >> Vignesh
On Thu, 20 Dec 2018 08:23:07 +0000 Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote: > Octal mode support patch series has dependency over these patches. > Should I send these two patches again or specifies them as dependency patches in the cover letter. No, you should either base your work on the master branch of the linux-next repo [1] (as suggested by Vignesh) or wait for 4.21-rc1/5.0-rc1 before sending a new version. [1]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/