From patchwork Thu Oct 25 15:02:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 194203 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 807612C00B1 for ; Fri, 26 Oct 2012 02:04:39 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TROwz-0001Y5-Jb; Thu, 25 Oct 2012 15:02:25 +0000 Received: from mail-qc0-f177.google.com ([209.85.216.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TROwu-0001Wo-KH for linux-arm-kernel@lists.infradead.org; Thu, 25 Oct 2012 15:02:23 +0000 Received: by mail-qc0-f177.google.com with SMTP id u28so759267qcs.36 for ; Thu, 25 Oct 2012 08:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=7L0fqwswPmioMWn93e5FWQuI2GWk0T0KpjXfLKCMla4=; b=GsStl5Za3eDv/weRbdkZrPb4XOYXqHOGqnfapPRPceFIb/ZHMoKeblKpLiqCIeFSVT sJ84pT2Kl3hKG5nGLzSCy7lfPXwsLc27eqLx9sSdM380RsMe1xPMJarNBPvfDnWSQEHm HjaPG0o3jlb/beRVJVjlVVEIlB8ggn45tjdmxx+CTQDfGXawWejufNHcxz5iMnDKl/3V bMarHioJGg9jeUdL29rpr/a38kZW/RVyb+pnf0zQyyg4rvUKV4Svy63k4m7NssLKmZxQ Pmk4gefaNM0xmr49lMMaA80oifNughanWLOvTwySKkAersj7dwzVXdAS6NwM1fbtB1oR vf9Q== MIME-Version: 1.0 Received: by 10.224.222.141 with SMTP id ig13mr4454342qab.75.1351177338125; Thu, 25 Oct 2012 08:02:18 -0700 (PDT) Received: by 10.229.114.30 with HTTP; Thu, 25 Oct 2012 08:02:18 -0700 (PDT) Date: Thu, 25 Oct 2012 23:02:18 +0800 Message-ID: Subject: [PATCH] ARM i.MX: fix error-valued pointer dereference in clk_register_gate2() From: Wei Yongjun To: kernel@pengutronix.de, linux@arm.linux.org.uk X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org From: Wei Yongjun The error-valued pointer clk is used for the arg of kfree, it should be kfree(gate) if clk_register() return ERR_PTR(). dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- arch/arm/mach-imx/clk-gate2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/clk-gate2.c b/arch/arm/mach-imx/clk-gate2.c index 3c1b8ff..cc49c7a 100644 --- a/arch/arm/mach-imx/clk-gate2.c +++ b/arch/arm/mach-imx/clk-gate2.c @@ -112,7 +112,7 @@ struct clk *clk_register_gate2(struct device *dev, const char *name, clk = clk_register(dev, &gate->hw); if (IS_ERR(clk)) - kfree(clk); + kfree(gate); return clk; }