| Message ID | 53cb17f5-6077-419a-8e5c-6c80f9dfa9dc@rwthex-w2-a.rwth-ad.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] sunxi-rsb: Include OF based modalias in device uevent | expand |
On Mon, Nov 27, 2017 at 08:05:34PM +0100, Stefan Brüns wrote: > Include the OF-based modalias in the uevent sent when registering devices > on the sunxi RSB bus, so that user space has a chance to autoload the > kernel module for the device. > > Fixes a regression caused by commit 3f241bfa60bd ("arm64: allwinner: a64: > pine64: Use dcdc1 regulator for mmc0"). When the axp20x-rsb module for > the AXP803 PMIC is built as a module, it is not loaded and the system > ends up with an disfunctional MMC controller. > > Cc: stable <stable@vger.kernel.org> > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Maxime
Hi, On Tue, Nov 28, 2017 at 11:47 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Nov 27, 2017 at 08:05:34PM +0100, Stefan Brüns wrote: >> Include the OF-based modalias in the uevent sent when registering devices >> on the sunxi RSB bus, so that user space has a chance to autoload the >> kernel module for the device. >> >> Fixes a regression caused by commit 3f241bfa60bd ("arm64: allwinner: a64: >> pine64: Use dcdc1 regulator for mmc0"). When the axp20x-rsb module for >> the AXP803 PMIC is built as a module, it is not loaded and the system >> ends up with an disfunctional MMC controller. >> Tags should be: Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus") Cc: stable <stable@vger.kernel.org> # 4.4.x 7a3b7cd332db of: device: Export of_device_{get_modalias, uvent_modalias} to modules >> Cc: stable <stable@vger.kernel.org> >> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Acked-by: Chen-Yu Tsai <wens@csie.org> Maxime, could you merge this as a fix to get it in fast? ChenYu
On Tue, Dec 05, 2017 at 03:28:25PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Tue, Nov 28, 2017 at 11:47 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Mon, Nov 27, 2017 at 08:05:34PM +0100, Stefan Brüns wrote: > >> Include the OF-based modalias in the uevent sent when registering devices > >> on the sunxi RSB bus, so that user space has a chance to autoload the > >> kernel module for the device. > >> > >> Fixes a regression caused by commit 3f241bfa60bd ("arm64: allwinner: a64: > >> pine64: Use dcdc1 regulator for mmc0"). When the axp20x-rsb module for > >> the AXP803 PMIC is built as a module, it is not loaded and the system > >> ends up with an disfunctional MMC controller. > >> > > Tags should be: > > Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced > Serial Bus") > Cc: stable <stable@vger.kernel.org> # 4.4.x 7a3b7cd332db of: device: > Export of_device_{get_modalias, uvent_modalias} to modules > > >> Cc: stable <stable@vger.kernel.org> > >> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Acked-by: Chen-Yu Tsai <wens@csie.org> > > Maxime, could you merge this as a fix to get it in fast? Applied, thanks! Maxime
diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index 328ca93781cf..1b76d9585902 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -178,6 +178,7 @@ static struct bus_type sunxi_rsb_bus = { .match = sunxi_rsb_device_match, .probe = sunxi_rsb_device_probe, .remove = sunxi_rsb_device_remove, + .uevent = of_device_uevent_modalias, }; static void sunxi_rsb_dev_release(struct device *dev)
Include the OF-based modalias in the uevent sent when registering devices on the sunxi RSB bus, so that user space has a chance to autoload the kernel module for the device. Fixes a regression caused by commit 3f241bfa60bd ("arm64: allwinner: a64: pine64: Use dcdc1 regulator for mmc0"). When the axp20x-rsb module for the AXP803 PMIC is built as a module, it is not loaded and the system ends up with an disfunctional MMC controller. Cc: stable <stable@vger.kernel.org> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- drivers/bus/sunxi-rsb.c | 1 + 1 file changed, 1 insertion(+)