fix refcount leak in mxs_get_ocotp()

Message ID	20220402013322.2410228-1-lv.ruyi@zte.com.cn
State	New
Headers	show Return-Path: <linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org> From: cgel.zte@gmail.com To: linux@armlinux.org.uk Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, lv.ruyi@zte.com.cn, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn> Subject: [PATCH] fix refcount leak in mxs_get_ocotp() Date: Sat, 2 Apr 2022 01:33:22 +0000 Message-Id: <20220402013322.2410228-1-lv.ruyi@zte.com.cn> MIME-Version: 1.0 preview: From: Lv Ruyi The of_find_compatible_node() function returns a node pointer with refcount incremented, use of_node_put() on it when done. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- arch/arm/mach-mxs/mach-mxs.c \| 1 + 1 file changed, 1 insertion(+) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:72d listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [cgel.zte[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org
Series	fix refcount leak in mxs_get_ocotp() \| expand fix refcount leak in mxs_get_ocotp()

Message ID

20220402013322.2410228-1-lv.ruyi@zte.com.cn

State

New

Headers

From: cgel.zte@gmail.com
To: linux@armlinux.org.uk
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
 festevam@gmail.com, linux-imx@nxp.com, lv.ruyi@zte.com.cn,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Zeal Robot <zealci@zte.com.cn>
Subject: [PATCH] fix refcount leak in mxs_get_ocotp()
Date: Sat,  2 Apr 2022 01:33:22 +0000
Message-Id: <20220402013322.2410228-1-lv.ruyi@zte.com.cn>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: 
 linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org

Series

fix refcount leak in mxs_get_ocotp() | expand

Commit Message

CGEL April 2, 2022, 1:33 a.m. UTC

From: Lv Ruyi <lv.ruyi@zte.com.cn>

The of_find_compatible_node() function returns a node pointer with
refcount incremented, use of_node_put() on it when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
 arch/arm/mach-mxs/mach-mxs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
index 25c9d184fa4c..6eb731f38727 100644
--- a/arch/arm/mach-mxs/mach-mxs.c
+++ b/arch/arm/mach-mxs/mach-mxs.c
@@ -98,6 +98,7 @@  static const u32 *mxs_get_ocotp(void)
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,ocotp");
 	ocotp_base = of_iomap(np, 0);
+	of_node_put(np);
 	WARN_ON(!ocotp_base);
 
 	mutex_lock(&ocotp_mutex);

fix refcount leak in mxs_get_ocotp()

Commit Message

Patch