diff mbox series

[3/5] ARM: dts: imx50: Add PHY node for usbotg and adjust clocks

Message ID 20190319152421.16179-4-j.neuschaefer@gmx.net
State New
Headers show
Series ARM: Initial devicetree for Kobo Aura | expand

Commit Message

Jonathan Neuschäfer March 19, 2019, 3:24 p.m. UTC
Even though the ChipIdea USB controller binding[1] doesn't specify the
properties that reference a PHY as required, the Linux driver
requires[2] such a reference.

The clock situation is like on i.MX53: The USB controller is clocked
from IMX5_CLK_USBOH3_GATE and the PHY from IMX5_CLK_USB_PHY1_GATE.

[1]: Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
[2]: Search for EINVAL in drivers/usb/chipidea/ci_hdrc_imx.c

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 arch/arm/boot/dts/imx50.dtsi | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

--
2.20.1

Comments

Shawn Guo March 22, 2019, 1:41 a.m. UTC | #1
On Tue, Mar 19, 2019 at 04:24:18PM +0100, Jonathan Neuschäfer wrote:
> Even though the ChipIdea USB controller binding[1] doesn't specify the
> properties that reference a PHY as required, the Linux driver
> requires[2] such a reference.
> 
> The clock situation is like on i.MX53: The USB controller is clocked
> from IMX5_CLK_USBOH3_GATE and the PHY from IMX5_CLK_USB_PHY1_GATE.
> 
> [1]: Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> [2]: Search for EINVAL in drivers/usb/chipidea/ci_hdrc_imx.c
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Applied, thanks.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
index ee1e3e8bf4ec..e5632ce24ba0 100644
--- a/arch/arm/boot/dts/imx50.dtsi
+++ b/arch/arm/boot/dts/imx50.dtsi
@@ -76,6 +76,14 @@ 
 		};
 	};

+	usbphy0: usbphy-0 {
+		compatible = "usb-nop-xceiv";
+		clocks = <&clks IMX5_CLK_USB_PHY1_GATE>;
+		clock-names = "main_clk";
+		#phy-cells = <0>;
+		status = "okay";
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
@@ -187,7 +195,8 @@ 
 				compatible = "fsl,imx50-usb", "fsl,imx27-usb";
 				reg = <0x53f80000 0x0200>;
 				interrupts = <18>;
-				clocks = <&clks IMX5_CLK_USB_PHY1_GATE>;
+				clocks = <&clks IMX5_CLK_USBOH3_GATE>;
+				fsl,usbphy = <&usbphy0>;
 				status = "disabled";
 			};