| Message ID | 20181122075742.31966-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry | expand |
On Thu, Nov 22, 2018 at 08:57:42AM +0100, Uwe Kleine-König wrote: > This way also the spi, i2c and other drivers are covered. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Hello, > > I was surprised by changes to the spi-imx driver[1]. To lessen the > chances that this happens again, I like making the IMX entry match all > relevant drivers. > > Best regards > Uwe > > [1] FTR: I didn't test yet, but I think > 987a2dfe3f0485a82d87106e7e1c43f35c1d3b09 broke i.MX31 and i.MX35. Even > though a later patch made spi_imx_dma_transfer fail if .setup_wml isn't > provided, I guess this only changes from a NULL pointer exception to a > non-functional driver. > > MAINTAINERS | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b755a89fa325..cb9cbaa1ba19 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com> > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Maintained > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > -F: arch/arm/mach-imx/ > -F: arch/arm/mach-mxs/ > -F: arch/arm/boot/dts/imx* > -F: arch/arm/configs/imx*_defconfig > -F: drivers/clk/imx/ > -F: drivers/firmware/imx/ > -F: drivers/soc/imx/ > -F: include/linux/firmware/imx/ > -F: include/soc/imx/ > +N: imx > +N: mxs This probably also matches drivers/media/i2c/*imx*, no? rsc
On Thu, Nov 22, 2018 at 09:17:04AM +0100, Robert Schwebel wrote: > On Thu, Nov 22, 2018 at 08:57:42AM +0100, Uwe Kleine-König wrote: > > This way also the spi, i2c and other drivers are covered. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > Hello, > > > > I was surprised by changes to the spi-imx driver[1]. To lessen the > > chances that this happens again, I like making the IMX entry match all > > relevant drivers. > > > > Best regards > > Uwe > > > > [1] FTR: I didn't test yet, but I think > > 987a2dfe3f0485a82d87106e7e1c43f35c1d3b09 broke i.MX31 and i.MX35. Even > > though a later patch made spi_imx_dma_transfer fail if .setup_wml isn't > > provided, I guess this only changes from a NULL pointer exception to a > > non-functional driver. > > > > MAINTAINERS | 11 ++--------- > > 1 file changed, 2 insertions(+), 9 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index b755a89fa325..cb9cbaa1ba19 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com> > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > > S: Maintained > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > -F: arch/arm/mach-imx/ > > -F: arch/arm/mach-mxs/ > > -F: arch/arm/boot/dts/imx* > > -F: arch/arm/configs/imx*_defconfig > > -F: drivers/clk/imx/ > > -F: drivers/firmware/imx/ > > -F: drivers/soc/imx/ > > -F: include/linux/firmware/imx/ > > -F: include/soc/imx/ > > +N: imx > > +N: mxs > > This probably also matches drivers/media/i2c/*imx*, no? Right, I didn't identify these as Sony stuff. Maybe NXP could sue them to rename their products? :-) So we need instead of N: imx better: N: (?<!drivers/media/i2c/)imx Or we add X: drivers/media/i2c/ ? Best regards Uwe
Hello Shawn, On Thu, Nov 22, 2018 at 09:35:58AM +0100, Uwe Kleine-König wrote: > On Thu, Nov 22, 2018 at 09:17:04AM +0100, Robert Schwebel wrote: > > On Thu, Nov 22, 2018 at 08:57:42AM +0100, Uwe Kleine-König wrote: > > > This way also the spi, i2c and other drivers are covered. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > --- > > > Hello, > > > > > > I was surprised by changes to the spi-imx driver[1]. To lessen the > > > chances that this happens again, I like making the IMX entry match all > > > relevant drivers. > > > > > > Best regards > > > Uwe > > > > > > [1] FTR: I didn't test yet, but I think > > > 987a2dfe3f0485a82d87106e7e1c43f35c1d3b09 broke i.MX31 and i.MX35. Even > > > though a later patch made spi_imx_dma_transfer fail if .setup_wml isn't > > > provided, I guess this only changes from a NULL pointer exception to a > > > non-functional driver. > > > > > > MAINTAINERS | 11 ++--------- > > > 1 file changed, 2 insertions(+), 9 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index b755a89fa325..cb9cbaa1ba19 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com> > > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > > > S: Maintained > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > > -F: arch/arm/mach-imx/ > > > -F: arch/arm/mach-mxs/ > > > -F: arch/arm/boot/dts/imx* > > > -F: arch/arm/configs/imx*_defconfig > > > -F: drivers/clk/imx/ > > > -F: drivers/firmware/imx/ > > > -F: drivers/soc/imx/ > > > -F: include/linux/firmware/imx/ > > > -F: include/soc/imx/ > > > +N: imx > > > +N: mxs > > > > This probably also matches drivers/media/i2c/*imx*, no? > > Right, I didn't identify these as Sony stuff. Maybe NXP could sue them > to rename their products? :-) > > So we need instead of > > N: imx > > better: > > N: (?<!drivers/media/i2c/)imx > > Or we add X: drivers/media/i2c/ ? I didn't receive any feedback from you. Are you positive in general to let the IMX entry match all relevant drivers? If yes, I'd respin this patch, probably using the more conservative "X: drivers/media/i2c" approach in stead of the negative look-behind trick. Best regards Uwe
On Wed, Dec 12, 2018 at 10:02:13AM +0100, Uwe Kleine-König wrote: ... > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index b755a89fa325..cb9cbaa1ba19 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com> > > > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > > > > S: Maintained > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > > > -F: arch/arm/mach-imx/ > > > > -F: arch/arm/mach-mxs/ > > > > -F: arch/arm/boot/dts/imx* > > > > -F: arch/arm/configs/imx*_defconfig > > > > -F: drivers/clk/imx/ > > > > -F: drivers/firmware/imx/ > > > > -F: drivers/soc/imx/ > > > > -F: include/linux/firmware/imx/ > > > > -F: include/soc/imx/ > > > > +N: imx > > > > +N: mxs > > > > > > This probably also matches drivers/media/i2c/*imx*, no? > > > > Right, I didn't identify these as Sony stuff. Maybe NXP could sue them > > to rename their products? :-) > > > > So we need instead of > > > > N: imx > > > > better: > > > > N: (?<!drivers/media/i2c/)imx > > > > Or we add X: drivers/media/i2c/ ? > > I didn't receive any feedback from you. Are you positive in general to > let the IMX entry match all relevant drivers? Yes. > If yes, I'd respin this > patch, probably using the more conservative "X: drivers/media/i2c" > approach in stead of the negative look-behind trick. We have some conflicting changes queued for merge window, so you may want to rebase on 4.21-rc1. Shawn
diff --git a/MAINTAINERS b/MAINTAINERS index b755a89fa325..cb9cbaa1ba19 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git -F: arch/arm/mach-imx/ -F: arch/arm/mach-mxs/ -F: arch/arm/boot/dts/imx* -F: arch/arm/configs/imx*_defconfig -F: drivers/clk/imx/ -F: drivers/firmware/imx/ -F: drivers/soc/imx/ -F: include/linux/firmware/imx/ -F: include/soc/imx/ +N: imx +N: mxs ARM/FREESCALE VYBRID ARM ARCHITECTURE M: Shawn Guo <shawnguo@kernel.org>
This way also the spi, i2c and other drivers are covered. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, I was surprised by changes to the spi-imx driver[1]. To lessen the chances that this happens again, I like making the IMX entry match all relevant drivers. Best regards Uwe [1] FTR: I didn't test yet, but I think 987a2dfe3f0485a82d87106e7e1c43f35c1d3b09 broke i.MX31 and i.MX35. Even though a later patch made spi_imx_dma_transfer fail if .setup_wml isn't provided, I guess this only changes from a NULL pointer exception to a non-functional driver. MAINTAINERS | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)