| Message ID | 1527664358-17844-3-git-send-email-Anson.Huang@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] ARM: imx: add L2 page power control for GPC | expand |
Hi Anson, On Wed, May 30, 2018 at 4:12 AM, Anson Huang <Anson.Huang@nxp.com> wrote: > i.MX6SLL supports ARM power off in cpu idle, better to reuse > i.MX6SX cpu idle driver instead of i.MX6SL which does NOT > support ARM power off. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > arch/arm/mach-imx/cpuidle-imx6sl.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-imx/cpuidle-imx6sl.c b/arch/arm/mach-imx/cpuidle-imx6sl.c > index fa8ead1..8d866fb 100644 > --- a/arch/arm/mach-imx/cpuidle-imx6sl.c > +++ b/arch/arm/mach-imx/cpuidle-imx6sl.c > @@ -12,7 +12,6 @@ > > #include "common.h" > #include "cpuidle.h" > -#include "hardware.h" The removal of this header file seems to be an unrelated change.
Hi, Fabio Anson Huang Best Regards! > -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: Wednesday, May 30, 2018 8:34 PM > To: Anson Huang <anson.huang@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>; Fabio > Estevam <fabio.estevam@nxp.com>; Russell King - ARM Linux > <linux@armlinux.org.uk>; dl-linux-imx <linux-imx@nxp.com>; moderated > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > <linux-arm-kernel@lists.infradead.org>; linux-kernel > <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH 3/3] ARM: imx: remove i.MX6SLL support in i.MX6SL cpu > idle driver > > Hi Anson, > > On Wed, May 30, 2018 at 4:12 AM, Anson Huang <Anson.Huang@nxp.com> > wrote: > > i.MX6SLL supports ARM power off in cpu idle, better to reuse i.MX6SX > > cpu idle driver instead of i.MX6SL which does NOT support ARM power > > off. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > arch/arm/mach-imx/cpuidle-imx6sl.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/mach-imx/cpuidle-imx6sl.c > > b/arch/arm/mach-imx/cpuidle-imx6sl.c > > index fa8ead1..8d866fb 100644 > > --- a/arch/arm/mach-imx/cpuidle-imx6sl.c > > +++ b/arch/arm/mach-imx/cpuidle-imx6sl.c > > @@ -12,7 +12,6 @@ > > > > #include "common.h" > > #include "cpuidle.h" > > -#include "hardware.h" > > The removal of this header file seems to be an unrelated change. This header file is no longer needed since no " cpu_is_imx6sl()" used in this file. Anson.
Hi Anson, On Wed, May 30, 2018 at 9:52 PM, Anson Huang <anson.huang@nxp.com> wrote: >> The removal of this header file seems to be an unrelated change. > > This header file is no longer needed since no " cpu_is_imx6sl()" used in this file. cpu_is_imx6sl() is not defined inside arch/arm/mach-imx/hardware.h header file.
Hi, Fabio Anson Huang Best Regards! > -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: Thursday, May 31, 2018 8:57 AM > To: Anson Huang <anson.huang@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>; Fabio > Estevam <fabio.estevam@nxp.com>; Russell King - ARM Linux > <linux@armlinux.org.uk>; dl-linux-imx <linux-imx@nxp.com>; moderated > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > <linux-arm-kernel@lists.infradead.org>; linux-kernel > <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH 3/3] ARM: imx: remove i.MX6SLL support in i.MX6SL cpu > idle driver > > Hi Anson, > > On Wed, May 30, 2018 at 9:52 PM, Anson Huang <anson.huang@nxp.com> > wrote: > > >> The removal of this header file seems to be an unrelated change. > > > > This header file is no longer needed since no " cpu_is_imx6sl()" used in this > file. > > cpu_is_imx6sl() is not defined inside arch/arm/mach-imx/hardware.h header > file. It is in arch/arm/mach-imx/mxc.h included by hardware.h, it is added by commit (dee5dee ARM: imx: Add basic msl support for imx6sll), so I removed it since we no longer need it. Anson.
On Wed, May 30, 2018 at 9:59 PM, Anson Huang <anson.huang@nxp.com> wrote: > It is in arch/arm/mach-imx/mxc.h included by hardware.h, it is added by commit > (dee5dee ARM: imx: Add basic msl support for imx6sll), so I removed it since we > no longer need it. Ah, OK: "mxc.h" is included by "hardware.h". Got it!
diff --git a/arch/arm/mach-imx/cpuidle-imx6sl.c b/arch/arm/mach-imx/cpuidle-imx6sl.c index fa8ead1..8d866fb 100644 --- a/arch/arm/mach-imx/cpuidle-imx6sl.c +++ b/arch/arm/mach-imx/cpuidle-imx6sl.c @@ -12,7 +12,6 @@ #include "common.h" #include "cpuidle.h" -#include "hardware.h" static int imx6sl_enter_wait(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) @@ -22,11 +21,9 @@ static int imx6sl_enter_wait(struct cpuidle_device *dev, * Software workaround for ERR005311, see function * description for details. */ - if (cpu_is_imx6sl()) - imx6sl_set_wait_clk(true); + imx6sl_set_wait_clk(true); cpu_do_idle(); - if (cpu_is_imx6sl()) - imx6sl_set_wait_clk(false); + imx6sl_set_wait_clk(false); imx6_set_lpm(WAIT_CLOCKED); return index;
i.MX6SLL supports ARM power off in cpu idle, better to reuse i.MX6SX cpu idle driver instead of i.MX6SL which does NOT support ARM power off. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- arch/arm/mach-imx/cpuidle-imx6sl.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)