diff mbox

ARM: imx35: add iim module to imx35.dtsi

Message ID 1473326895-19189-1-git-send-email-u.kleine-koenig@pengutronix.de
State New
Headers show

Commit Message

Uwe Kleine-König Sept. 8, 2016, 9:28 a.m. UTC
This is a prerequisite to remove the static mappings for imx35 devicetree
based machines.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/boot/dts/imx35.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Fabio Estevam Sept. 8, 2016, 4:21 p.m. UTC | #1
Hi Uwe,

On Thu, Sep 8, 2016 at 6:28 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> This is a prerequisite to remove the static mappings for imx35 devicetree
> based machines.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx35.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
> index 490b7b44f1e7..f812d586c5ce 100644
> --- a/arch/arm/boot/dts/imx35.dtsi
> +++ b/arch/arm/boot/dts/imx35.dtsi
> @@ -309,6 +309,13 @@
>                                 status = "disabled";
>                         };
>
> +                       iim@53ff0000 {
> +                               compatible = "fsl,imx35-iim";

Where is "fsl,imx35-iim" defined?
Uwe Kleine-König Sept. 8, 2016, 5:55 p.m. UTC | #2
On Thu, Sep 08, 2016 at 01:21:49PM -0300, Fabio Estevam wrote:
> Hi Uwe,
> 
> On Thu, Sep 8, 2016 at 6:28 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > This is a prerequisite to remove the static mappings for imx35 devicetree
> > based machines.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx35.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
> > index 490b7b44f1e7..f812d586c5ce 100644
> > --- a/arch/arm/boot/dts/imx35.dtsi
> > +++ b/arch/arm/boot/dts/imx35.dtsi
> > @@ -309,6 +309,13 @@
> >                                 status = "disabled";
> >                         };
> >
> > +                       iim@53ff0000 {
> > +                               compatible = "fsl,imx35-iim";
> 
> Where is "fsl,imx35-iim" defined?

right next to the other fsl,imx*-iim :-)

By the way, compared to the other imx*.dtsi I didn't declare
compatibility to fsl,imx27-iim. I checked the i.MX25 reference manual
and the i.MX35 looked different. Didn't check for imx5x and the i.MX27
RM doesn't describe the registers. What do you think?

Best regards
Uwe
Fabio Estevam Sept. 8, 2016, 6:09 p.m. UTC | #3
On Thu, Sep 8, 2016 at 2:55 PM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

>> Where is "fsl,imx35-iim" defined?
>
> right next to the other fsl,imx*-iim :-)

Ok,  "fsl,imx35-iim" is not being used arch/arm/mach-imx/cpu-imx35.c currently.

I suppose you want to replace
 "rev = imx_readl(MX35_IO_ADDRESS(MX35_IIM_BASE_ADDR + MXC_IIMSREV));"

by retrieving the base address via dt, like we do in
imx5_read_srev_reg() at arch/arm/mach-imx/cpu-imx5.c.


> By the way, compared to the other imx*.dtsi I didn't declare
> compatibility to fsl,imx27-iim. I checked the i.MX25 reference manual
> and the i.MX35 looked different. Didn't check for imx5x and the i.MX27
> RM doesn't describe the registers. What do you think?

I think this is fine as is, so:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Uwe Kleine-König Sept. 8, 2016, 6:18 p.m. UTC | #4
Hello Fabio,

On Thu, Sep 08, 2016 at 03:09:17PM -0300, Fabio Estevam wrote:
> On Thu, Sep 8, 2016 at 2:55 PM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> 
> >> Where is "fsl,imx35-iim" defined?
> >
> > right next to the other fsl,imx*-iim :-)
> 
> Ok,  "fsl,imx35-iim" is not being used arch/arm/mach-imx/cpu-imx35.c currently.
> 
> I suppose you want to replace
>  "rev = imx_readl(MX35_IO_ADDRESS(MX35_IIM_BASE_ADDR + MXC_IIMSREV));"
> 
> by retrieving the base address via dt, like we do in
> imx5_read_srev_reg() at arch/arm/mach-imx/cpu-imx5.c.

Yes, that's the plan, imx5_read_srev_reg could even be used for this, so
I intend to rename it and move it to a place where it is compiled for
i.MX[23]5.

Best regards
Uwe
Shawn Guo Sept. 9, 2016, 6:19 a.m. UTC | #5
On Thu, Sep 08, 2016 at 11:28:15AM +0200, Uwe Kleine-König wrote:
> This is a prerequisite to remove the static mappings for imx35 devicetree
> based machines.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied, thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
index 490b7b44f1e7..f812d586c5ce 100644
--- a/arch/arm/boot/dts/imx35.dtsi
+++ b/arch/arm/boot/dts/imx35.dtsi
@@ -309,6 +309,13 @@ 
 				status = "disabled";
 			};
 
+			iim@53ff0000 {
+				compatible = "fsl,imx35-iim";
+				reg = <0x53ff0000 0x4000>;
+				interrupts = <19>;
+				clocks = <&clks 80>;
+			};
+
 			usbotg: usb@53ff4000 {
 				compatible = "fsl,imx35-usb", "fsl,imx27-usb";
 				reg = <0x53ff4000 0x0200>;