| Message ID | 1406868897-26874-5-git-send-email-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
Hi, On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber <afaerber@suse.de> wrote: > exynos5250-cros-common.dtsi had an empty /chosen node. > Fill in exemplary boot arguments. > > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > v5: New > Cleanup for /chosen node moved into -snow.dts. > > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index 7680d5e03fb3..c4b0c73c736d 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -27,6 +27,7 @@ > }; > > chosen { > + bootargs = "console=tty1"; As mentioned earlier, I don't think this is a particularly useful change. Just this boot argument is not enough to boot with anyway, so listing it doesn't really help anyone. In theory you could make some assertion about what the "most popular" boot device and filesystem is, but it seems unlikely to cover the majority of the cases. I won't NAK this change myself, but I certainly won't push for it. -Doug
Hi Doug, Am 01.08.2014 22:28, schrieb Doug Anderson: > On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber <afaerber@suse.de> wrote: >> exynos5250-cros-common.dtsi had an empty /chosen node. >> Fill in exemplary boot arguments. >> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> v5: New >> Cleanup for /chosen node moved into -snow.dts. >> >> arch/arm/boot/dts/exynos5250-snow.dts | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >> index 7680d5e03fb3..c4b0c73c736d 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow.dts >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >> @@ -27,6 +27,7 @@ >> }; >> >> chosen { >> + bootargs = "console=tty1"; > > As mentioned earlier, I don't think this is a particularly useful > change. Just this boot argument is not enough to boot with anyway, so > listing it doesn't really help anyone. In theory you could make some > assertion about what the "most popular" boot device and filesystem is, > but it seems unlikely to cover the majority of the cases. > > I won't NAK this change myself, but I certainly won't push for it. This patch should be entirely optional. I believe you said it wasn't necessary because the bootloader supplies it. My point is that someone needs to know what to put into the bootargs (setenv / boot.scr / uEnv.txt) - knowing whether it's ttySAC3 vs. ttySAC2 vs. ttyS0 etc. has been pretty handy for me. In this case, Snow and Spring use an identical console, so not sure if it might be tty2 or something elsewhere? My question of what to use for linux,stdout-path (which was elsewhere mentioned as successor to bootargs in that regard) remained unanswered. Should it point to the dp-controller node or what? Andreas
Andreas, On Fri, Aug 1, 2014 at 2:10 PM, Andreas Färber <afaerber@suse.de> wrote: > Hi Doug, > > Am 01.08.2014 22:28, schrieb Doug Anderson: >> On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber <afaerber@suse.de> wrote: >>> exynos5250-cros-common.dtsi had an empty /chosen node. >>> Fill in exemplary boot arguments. >>> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> v5: New >>> Cleanup for /chosen node moved into -snow.dts. >>> >>> arch/arm/boot/dts/exynos5250-snow.dts | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >>> index 7680d5e03fb3..c4b0c73c736d 100644 >>> --- a/arch/arm/boot/dts/exynos5250-snow.dts >>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >>> @@ -27,6 +27,7 @@ >>> }; >>> >>> chosen { >>> + bootargs = "console=tty1"; >> >> As mentioned earlier, I don't think this is a particularly useful >> change. Just this boot argument is not enough to boot with anyway, so >> listing it doesn't really help anyone. In theory you could make some >> assertion about what the "most popular" boot device and filesystem is, >> but it seems unlikely to cover the majority of the cases. >> >> I won't NAK this change myself, but I certainly won't push for it. > > This patch should be entirely optional. > > I believe you said it wasn't necessary because the bootloader supplies > it. My point is that someone needs to know what to put into the bootargs > (setenv / boot.scr / uEnv.txt) - knowing whether it's ttySAC3 vs. > ttySAC2 vs. ttyS0 etc. has been pretty handy for me. In this case, Snow > and Spring use an identical console, so not sure if it might be tty2 or > something elsewhere? ...but in your case you're not including any of that info. tty1 is a LCD console, isn't it? > My question of what to use for linux,stdout-path (which was elsewhere > mentioned as successor to bootargs in that regard) remained unanswered. > Should it point to the dp-controller node or what? No idea since I've never heard of linux,stdout-path other than your emails. Maybe someone else can chime in and I'll learn something. ;) -Doug
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 7680d5e03fb3..c4b0c73c736d 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -27,6 +27,7 @@ }; chosen { + bootargs = "console=tty1"; }; gpio-keys {
exynos5250-cros-common.dtsi had an empty /chosen node. Fill in exemplary boot arguments. Signed-off-by: Andreas Färber <afaerber@suse.de> --- v5: New Cleanup for /chosen node moved into -snow.dts. arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed, 1 insertion(+)