From patchwork Fri Nov 16 14:39:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christoph Fritz X-Patchwork-Id: 199643 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6803A2C0093 for ; Sat, 17 Nov 2012 01:42:30 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TZN5K-0001tn-RD; Fri, 16 Nov 2012 14:39:58 +0000 Received: from mail-ea0-f177.google.com ([209.85.215.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TZN5F-0001tU-F9 for linux-arm-kernel@lists.infradead.org; Fri, 16 Nov 2012 14:39:54 +0000 Received: by mail-ea0-f177.google.com with SMTP id n13so1099066eaa.36 for ; Fri, 16 Nov 2012 06:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=sDCvnZ7RGEUPCv8Dkh8xfrN0jYPGLNX0tkR2eaoP0Qs=; b=0kXSYZhZigauAqA3ho8oAw7pgnSj5CORMfMVo/B1BdUfurxoYxMMJwWiyJ+jDBFOoB FBwwg/U/OgwgheuPUfeKaQvGjn2KOjITB5aA+S7M9t1vcA8+1iz6bJpj2wcuUqOGZ7U/ ZWkf+2AqmJtybIWyGzEKT/TSiYTxkM1YEJ1aJevr8nAis6u6FGHTsE+uCba/5M4JmxJX qZRqtIV4imhMfH7X8eF48ftKP5Xb6MwWvxd5f+g0OLt0la174rDVU24gtnTcebdiwVUY Xr7VQcCSbscIjNu1dHF2L0h4gtDUw/o8Q1F6vKhdpc0JFVxeotYRjf1z3iQ3C38sQtLH xI/g== Received: by 10.14.182.70 with SMTP id n46mr6020917eem.5.1353076791580; Fri, 16 Nov 2012 06:39:51 -0800 (PST) Received: from [127.0.0.1] (fritzc.com. [78.47.220.26]) by mx.google.com with ESMTPS id g5sm3862521eem.4.2012.11.16.06.39.50 (version=SSLv3 cipher=OTHER); Fri, 16 Nov 2012 06:39:50 -0800 (PST) Subject: [PATCH] ARM: imx: ehci: fix host power mask bit From: Christoph Fritz To: Eric =?ISO-8859-1?Q?B=E9nard?= In-Reply-To: <20121116142531.228251f6@eb-e6520> References: <1353063197.3647.27.camel@mars> <20121116142531.228251f6@eb-e6520> Date: Fri, 16 Nov 2012 15:39:24 +0100 Message-ID: <1353076764.3647.35.camel@mars> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121116_093953_736480_5984E963 X-CRM114-Status: GOOD ( 13.13 ) X-Spam-Score: -1.7 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (chf.fritz[at]googlemail.com) 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.9 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list Cc: Fabio Estevam , Sascha Hauer , Greg Kroah-Hartman , Daniel Mack , Stable , "Hans J. Koch" , Michael Burkey , Christian Hemp , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org This patch sets HPM (Host power mask bit) to bit 16 according to i.MX Reference Manual. Falsely it was set to bit 8, but this controls pull-up Impedance. Reported-by: Michael Burkey Cc: Stable Signed-off-by: Christoph Fritz Acked-by: Eric Bénard --- arch/arm/mach-imx/ehci-imx25.c | 2 +- arch/arm/mach-imx/ehci-imx35.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-imx/ehci-imx25.c b/arch/arm/mach-imx/ehci-imx25.c index 27e40d1..134c190 100644 --- a/arch/arm/mach-imx/ehci-imx25.c +++ b/arch/arm/mach-imx/ehci-imx25.c @@ -30,7 +30,7 @@ #define MX25_H1_SIC_SHIFT 21 #define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT) #define MX25_H1_PP_BIT (1 << 18) -#define MX25_H1_PM_BIT (1 << 8) +#define MX25_H1_PM_BIT (1 << 16) #define MX25_H1_IPPUE_UP_BIT (1 << 7) #define MX25_H1_IPPUE_DOWN_BIT (1 << 6) #define MX25_H1_TLL_BIT (1 << 5) diff --git a/arch/arm/mach-imx/ehci-imx35.c b/arch/arm/mach-imx/ehci-imx35.c index a596f70..554e7cc 100644 --- a/arch/arm/mach-imx/ehci-imx35.c +++ b/arch/arm/mach-imx/ehci-imx35.c @@ -30,7 +30,7 @@ #define MX35_H1_SIC_SHIFT 21 #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT) #define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16) #define MX35_H1_IPPUE_UP_BIT (1 << 7) #define MX35_H1_IPPUE_DOWN_BIT (1 << 6) #define MX35_H1_TLL_BIT (1 << 5)