| Message ID | 1314699093-30276-2-git-send-email-jason.chen@freescale.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Aug 30, 2011 at 06:11:33PM +0800, jason.chen@freescale.com wrote: > diff --git a/arch/arm/plat-mxc/include/mach/devices-common.h b/arch/arm/plat-mxc/include/mach/devices-common.h > index 524538a..4409406 100644 > --- a/arch/arm/plat-mxc/include/mach/devices-common.h > +++ b/arch/arm/plat-mxc/include/mach/devices-common.h > @@ -301,3 +301,11 @@ struct platform_device *__init imx_add_spi_imx( > struct platform_device *imx_add_imx_dma(void); > struct platform_device *imx_add_imx_sdma(char *name, > resource_size_t iobase, int irq, struct sdma_platform_data *pdata); > + > +#include <linux/pwm_backlight.h> > +static inline struct platform_device *__init imx_add_pwm_backlight( > + const int id, const struct platform_pwm_backlight_data *pdata) > +{ > + return platform_device_register_resndata(NULL, "pwm-backlight",\ > + id, NULL, 0, pdata, sizeof(*pdata)); > +} 1. It's normal for include statements to be at the top of the file. 2. \ at the end of a line is not necessary to split a line of C code - it really only matters for strings and the preprocessor. 3. 'const int id' is just silly. What are you const'ing? The _copy_ of the parameter that was passed? const doesn't make sense for plain integer arguments.
hi, Russell, Pls see my comments below: Jason Chen / 陈 杰 Tel: +86 21 28937178 Freescale Semiconductor (China) Limited Shanghai Branch Office No.192 Liangjing Rd., Pudong New Area, Shanghai, 201203
diff --git a/arch/arm/mach-mx5/Kconfig b/arch/arm/mach-mx5/Kconfig index b4e7c58..1463cd3 100644 --- a/arch/arm/mach-mx5/Kconfig +++ b/arch/arm/mach-mx5/Kconfig @@ -202,6 +202,7 @@ config MACH_MX53_LOCO select IMX_HAVE_PLATFORM_IMX2_WDT select IMX_HAVE_PLATFORM_IMX_I2C select IMX_HAVE_PLATFORM_IMX_UART + select IMX_HAVE_PLATFORM_MXC_PWM select IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX select IMX_HAVE_PLATFORM_GPIO_KEYS select LEDS_GPIO_REGISTER diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c index 4e1d51d..ae96128 100644 --- a/arch/arm/mach-mx5/board-mx53_loco.c +++ b/arch/arm/mach-mx5/board-mx53_loco.c @@ -22,6 +22,7 @@ #include <linux/clk.h> #include <linux/delay.h> #include <linux/gpio.h> +#include <linux/pwm_backlight.h> #include <mach/common.h> #include <mach/hardware.h> @@ -257,6 +258,13 @@ static const struct gpio_led_platform_data mx53loco_leds_data __initconst = { .num_leds = ARRAY_SIZE(mx53loco_leds), }; +static struct platform_pwm_backlight_data loco_pwm_backlight_data = { + .pwm_id = 1, + .max_brightness = 255, + .dft_brightness = 128, + .pwm_period_ns = 50000, +}; + static void __init mx53_loco_board_init(void) { imx53_soc_init(); @@ -273,6 +281,9 @@ static void __init mx53_loco_board_init(void) imx53_add_sdhci_esdhc_imx(2, &mx53_loco_sd3_data); imx_add_gpio_keys(&loco_button_data); gpio_led_register_device(-1, &mx53loco_leds_data); + + imx53_add_mxc_pwm(1); + imx_add_pwm_backlight(0, &loco_pwm_backlight_data); } static void __init mx53_loco_timer_init(void) diff --git a/arch/arm/plat-mxc/include/mach/devices-common.h b/arch/arm/plat-mxc/include/mach/devices-common.h index 524538a..4409406 100644 --- a/arch/arm/plat-mxc/include/mach/devices-common.h +++ b/arch/arm/plat-mxc/include/mach/devices-common.h @@ -301,3 +301,11 @@ struct platform_device *__init imx_add_spi_imx( struct platform_device *imx_add_imx_dma(void); struct platform_device *imx_add_imx_sdma(char *name, resource_size_t iobase, int irq, struct sdma_platform_data *pdata); + +#include <linux/pwm_backlight.h> +static inline struct platform_device *__init imx_add_pwm_backlight( + const int id, const struct platform_pwm_backlight_data *pdata) +{ + return platform_device_register_resndata(NULL, "pwm-backlight",\ + id, NULL, 0, pdata, sizeof(*pdata)); +}