mbox series

[V5,0/6] ARM: dts: imx6ull: Add chargebyte Tarragon support

Message ID 20230404080243.9613-1-stefan.wahren@chargebyte.com
Headers show
Series ARM: dts: imx6ull: Add chargebyte Tarragon support | expand

Message

Stefan Wahren April 4, 2023, 8:02 a.m. UTC
This series adds the support for chargebyte Tarragon, which is an
Electrical Vehicle Supply Equipment (EVSE) for AC charging stations
(according to IEC 61851, ISO 15118).

The Tarragon board is based on an i.MX6ULL SoC and is available in
4 variants (Master, Slave, SlaveXT, Micro), which provide more or
less peripherals.

Supported features:
  * 512 MB DDR RAM
  * eMMC
  * Debug UART
  * 100 Mbit Ethernet
  * USB 2.0 Host interface
  * Powerline communication (QCA700x)
  * 2x RS485
  * Digital in- and outputs (12 V)
  * One-Wire master for external temp sensors
  * 2x relay outputs
  * 2x motor interfaces
  
The Tarragon hardware is bundled with a charging stack under the name
Charge Control C: 
https://chargebyte.com/products/charging-station-communication/charge-control-c

This series is rebased on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git?h=for-next

Changes in V5:
- allow child nodes in DS2482 binding as noted by Krzysztof and Rob

Changes in V4:
- introduce dedicated dt-binding for Maxim I2C to 1-W bridges
- add Krzysztof's Acked-by

Changes in V3:
- dropped already applied iio patches
- renamed pinctrl_qca700x_mains_spi to pinctrl_ecspi4
- dropped Tarragon container nodes as suggested by Shawn
- sort the pinctrl groups alphabetically also suggested by Shawn

Changes in V2:
- after fixing technical problems send patches directly from chargebyte address
  and drop the related signed-off-by
- add Krzysztof's Acked-by
- improve commit messages (patch 3, 4, 5)
- make iis328dq fallback to lis331dl as suggested by Jonathan
- fix order of Tarragon entries in FSL schema
- improve Tarragon led node names and drop label as suggested by Krzysztof
- change Tarragon SVNS pinctrl settings after internal discussion
  with chargebyte hardware team
- drop broken-cd in Tarragon common DTSI which is not necessary for eMMC
- add no-sd and no-sdio for eMMC interface of Tarragon

Stefan Wahren (6):
  dt-bindings: vendor-prefixes: add chargebyte
  dt-bindings: w1: Add DS2482/DS2484 I2C to 1-W bridges
  w1: ds2482: add i2c id for DS2484
  dt-bindings: ARM: fsl: Add chargebyte Tarragon
  ARM: dts: imx6ull: Add chargebyte Tarragon support
  ARM: imx_v6_v7_defconfig: Enable Tarragon peripheral drivers

 .../devicetree/bindings/arm/fsl.yaml          |   9 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 .../devicetree/bindings/w1/maxim,ds2482.yaml  |  44 +
 arch/arm/boot/dts/Makefile                    |   4 +
 .../arm/boot/dts/imx6ull-tarragon-common.dtsi | 852 ++++++++++++++++++
 arch/arm/boot/dts/imx6ull-tarragon-master.dts |  82 ++
 arch/arm/boot/dts/imx6ull-tarragon-micro.dts  |  10 +
 arch/arm/boot/dts/imx6ull-tarragon-slave.dts  |  32 +
 .../arm/boot/dts/imx6ull-tarragon-slavext.dts |  64 ++
 arch/arm/configs/imx_v6_v7_defconfig          |   6 +
 drivers/w1/masters/ds2482.c                   |   1 +
 11 files changed, 1106 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
 create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-common.dtsi
 create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-master.dts
 create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-micro.dts
 create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-slave.dts
 create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-slavext.dts

Comments

Krzysztof Kozlowski April 4, 2023, 8:16 a.m. UTC | #1
On 04/04/2023 10:02, Stefan Wahren wrote:
> This adds a dedicated devicetree binding for the Maxim DS2482/DS2484
> I2C to 1-W bridges, which can be extended later for further features
> (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes
> needs to be allowed here.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Rob Herring (Arm) April 4, 2023, 1:39 p.m. UTC | #2
On Tue, Apr 04, 2023 at 10:02:39AM +0200, Stefan Wahren wrote:
> This adds a dedicated devicetree binding for the Maxim DS2482/DS2484
> I2C to 1-W bridges, which can be extended later for further features
> (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes
> needs to be allowed here.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> ---
>  .../devicetree/bindings/w1/maxim,ds2482.yaml  | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml

Reviewed-by: Rob Herring <robh@kernel.org>
Shawn Guo April 6, 2023, 1:46 a.m. UTC | #3
On Tue, Apr 04, 2023 at 10:02:41AM +0200, Stefan Wahren wrote:
> This adds the compatibles for the chargebyte Tarragon boards.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied 4 ~ 6, thanks!
Shawn Guo April 6, 2023, 1:47 a.m. UTC | #4
On Tue, Apr 04, 2023 at 10:02:38AM +0200, Stefan Wahren wrote:
> chargebyte supplies hardware and software products for all
> aspects of charging communication.
> https://chargebyte.com/
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied, thanks!
Stefan Wahren April 6, 2023, 6:57 a.m. UTC | #5
Hi,

Am 06.04.23 um 03:46 schrieb Shawn Guo:
> On Tue, Apr 04, 2023 at 10:02:41AM +0200, Stefan Wahren wrote:
>> This adds the compatibles for the chargebyte Tarragon boards.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Applied 4 ~ 6, thanks!

thanks a lot.

What happens to patch 2 & 3?

Who take care of them?
Shawn Guo April 6, 2023, 8:35 a.m. UTC | #6
On Thu, Apr 06, 2023 at 08:57:01AM +0200, Stefan Wahren wrote:
> Hi,
> 
> Am 06.04.23 um 03:46 schrieb Shawn Guo:
> > On Tue, Apr 04, 2023 at 10:02:41AM +0200, Stefan Wahren wrote:
> > > This adds the compatibles for the chargebyte Tarragon boards.
> > > 
> > > Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> > Applied 4 ~ 6, thanks!
> 
> thanks a lot.
> 
> What happens to patch 2 & 3?
> 
> Who take care of them?

I guess the patches need to be applied through w1 subsystem.  Greg seems
taking care of it from git history.

Shawn
Stefan Wahren April 6, 2023, 9:53 a.m. UTC | #7
Hi Greg,

Am 04.04.23 um 15:39 schrieb Rob Herring:
> On Tue, Apr 04, 2023 at 10:02:39AM +0200, Stefan Wahren wrote:
>> This adds a dedicated devicetree binding for the Maxim DS2482/DS2484
>> I2C to 1-W bridges, which can be extended later for further features
>> (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes
>> needs to be allowed here.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
>> ---
>>   .../devicetree/bindings/w1/maxim,ds2482.yaml  | 44 +++++++++++++++++++
>>   1 file changed, 44 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Shawn Guo applied all patches from this series [1] except of this one 
and patch 3, which probably should go via your 1-w tree?

Unfortunately no feedback from Evgeniy so far. Should i resend these two 
patches for you?

Best regards
Stefan

[1] - 
https://lore.kernel.org/linux-arm-kernel/20230404080243.9613-1-stefan.wahren@chargebyte.com/T/

> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Greg Kroah-Hartman April 6, 2023, 9:58 a.m. UTC | #8
On Thu, Apr 06, 2023 at 11:53:28AM +0200, Stefan Wahren wrote:
> Hi Greg,
> 
> Am 04.04.23 um 15:39 schrieb Rob Herring:
> > On Tue, Apr 04, 2023 at 10:02:39AM +0200, Stefan Wahren wrote:
> > > This adds a dedicated devicetree binding for the Maxim DS2482/DS2484
> > > I2C to 1-W bridges, which can be extended later for further features
> > > (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes
> > > needs to be allowed here.
> > > 
> > > Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> > > ---
> > >   .../devicetree/bindings/w1/maxim,ds2482.yaml  | 44 +++++++++++++++++++
> > >   1 file changed, 44 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Shawn Guo applied all patches from this series [1] except of this one and
> patch 3, which probably should go via your 1-w tree?
> 
> Unfortunately no feedback from Evgeniy so far. Should i resend these two
> patches for you?

Please do.

thanks,

greg k-h
Evgeniy Polyakov April 6, 2023, 11:47 a.m. UTC | #9
Stefan, Greg, hi

On 06/04/2023 10:58, Greg Kroah-Hartman wrote:
> On Thu, Apr 06, 2023 at 11:53:28AM +0200, Stefan Wahren wrote:
>> Unfortunately no feedback from Evgeniy so far. Should i resend these two
>> patches for you?
> 
> Please do.

Thank you for the patches Stefan, but I'm no longer a w1 maintainer, 
sorry I haven't updated the maintainers file, please send all w1 patches 
to Greg.
Krzysztof Kozlowski April 6, 2023, 6:10 p.m. UTC | #10
On 06/04/2023 13:47, Evgeniy Polyakov wrote:
> Stefan, Greg, hi
> 
> On 06/04/2023 10:58, Greg Kroah-Hartman wrote:
>> On Thu, Apr 06, 2023 at 11:53:28AM +0200, Stefan Wahren wrote:
>>> Unfortunately no feedback from Evgeniy so far. Should i resend these two
>>> patches for you?
>>
>> Please do.
> 
> Thank you for the patches Stefan, but I'm no longer a w1 maintainer, 
> sorry I haven't updated the maintainers file, please send all w1 patches 
> to Greg.

Thanks Evgeniy.

If the one-wire subsystem is orphaned, I can manage the patches to
offload Greg a bit.

Best regards,
Krzysztof
Krzysztof Kozlowski April 15, 2023, 9:34 a.m. UTC | #11
On 06/04/2023 20:10, Krzysztof Kozlowski wrote:
> On 06/04/2023 13:47, Evgeniy Polyakov wrote:
>> Stefan, Greg, hi
>>
>> On 06/04/2023 10:58, Greg Kroah-Hartman wrote:
>>> On Thu, Apr 06, 2023 at 11:53:28AM +0200, Stefan Wahren wrote:
>>>> Unfortunately no feedback from Evgeniy so far. Should i resend these two
>>>> patches for you?
>>>
>>> Please do.
>>
>> Thank you for the patches Stefan, but I'm no longer a w1 maintainer, 
>> sorry I haven't updated the maintainers file, please send all w1 patches 
>> to Greg.
> 
> Thanks Evgeniy.
> 
> If the one-wire subsystem is orphaned, I can manage the patches to
> offload Greg a bit.

There was not feedback on my proposal, which I am optimistically going
to understand as "go ahead". :)

I'll send a patch, assuming Evgeniy that you are not planning to
maintain w1 anymore and a new maintainer would be useful.

Best regards,
Krzysztof
Evgeniy Polyakov April 15, 2023, 10:25 p.m. UTC | #12
Hi Krzysztof

On 15/04/2023 10:34, Krzysztof Kozlowski wrote:
>>> Thank you for the patches Stefan, but I'm no longer a w1 maintainer,
>>> sorry I haven't updated the maintainers file, please send all w1 patches
>>> to Greg.
>>
>> Thanks Evgeniy.
>>
>> If the one-wire subsystem is orphaned, I can manage the patches to
>> offload Greg a bit.
> 
> There was not feedback on my proposal, which I am optimistically going
> to understand as "go ahead". :)
> 
> I'll send a patch, assuming Evgeniy that you are not planning to
> maintain w1 anymore and a new maintainer would be useful.

Greg has been managing all the w1 patches for last years and as far as I 
understand, in particular since I stepped out, I'm totally not against 
anyone picking up the queue from him or doing it the way I've been doing 
through his tree, but please discuss it with him and come up with the 
solution which works best, I have no word in it.

Thank you.