| Message ID | 7f7ed86e-16a4-3f5c-67d8-8fbc49bb626c@omp.ru |
|---|---|
| State | New |
| Headers | show |
| Series | ata: libata-sff: make ata_resources_present() return 'bool' | expand |
On 2/13/22 20:50, Sergey Shtylyov wrote: > ata_resources_present() returns 1 if the primary/secondary channel's PCI > resources are present, 0 if not -- the 'bool' type fits somewhat better > here than 'int'... > > Use the *= operator, while at it... > > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Applied to for-5.18. Thanks !
Index: libata/drivers/ata/libata-sff.c =================================================================== --- libata.orig/drivers/ata/libata-sff.c +++ libata/drivers/ata/libata-sff.c @@ -2174,18 +2174,18 @@ EXPORT_SYMBOL_GPL(ata_sff_std_ports); #ifdef CONFIG_PCI -static int ata_resources_present(struct pci_dev *pdev, int port) +static bool ata_resources_present(struct pci_dev *pdev, int port) { int i; /* Check the PCI resources for this channel are enabled */ - port = port * 2; + port *= 2; for (i = 0; i < 2; i++) { if (pci_resource_start(pdev, port + i) == 0 || pci_resource_len(pdev, port + i) == 0) - return 0; + return false; } - return 1; + return true; } /**
ata_resources_present() returns 1 if the primary/secondary channel's PCI resources are present, 0 if not -- the 'bool' type fits somewhat better here than 'int'... Use the *= operator, while at it... Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> --- This patch is against the 'for-next' branch of Damien Le Moal's 'libata.git' repo. drivers/ata/libata-sff.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)