| Message ID | 76a2bbd9fb944dbefdb8d429d0a85937d56a3d6f.1683035327.git.michal.simek@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: ata: ahci-ceva: Cover all 4 iommus entries | expand |
On 02/05/2023 15:48, Michal Simek wrote: > Current only one entry is enabled but IP itself is using 4 different IDs > which are already listed in zynqmp.dtsi. > > sata: ahci@fd0c0000 { > compatible = "ceva,ahci-1v84"; > ... > iommus = <&smmu 0x4c0>, <&smmu 0x4c1>, > <&smmu 0x4c2>, <&smmu 0x4c3>; > }; > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 5/2/23 22:48, Michal Simek wrote: > Current only one entry is enabled but IP itself is using 4 different IDs > which are already listed in zynqmp.dtsi. > > sata: ahci@fd0c0000 { > compatible = "ceva,ahci-1v84"; > ... > iommus = <&smmu 0x4c0>, <&smmu 0x4c1>, > <&smmu 0x4c2>, <&smmu 0x4c3>; > }; > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml > index 9b31f864e071..71364c6081ff 100644 > --- a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml > +++ b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml > @@ -32,7 +32,7 @@ properties: > maxItems: 1 > > iommus: > - maxItems: 1 > + maxItems: 4 > > power-domains: > maxItems: 1 Is this a bug fix ? If yes, what about adding Fixes & Cc: stable tags ?
On 5/4/23 04:34, Damien Le Moal wrote: > On 5/2/23 22:48, Michal Simek wrote: >> Current only one entry is enabled but IP itself is using 4 different IDs >> which are already listed in zynqmp.dtsi. >> >> sata: ahci@fd0c0000 { >> compatible = "ceva,ahci-1v84"; >> ... >> iommus = <&smmu 0x4c0>, <&smmu 0x4c1>, >> <&smmu 0x4c2>, <&smmu 0x4c3>; >> }; >> >> Signed-off-by: Michal Simek <michal.simek@amd.com> >> --- >> >> Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml >> index 9b31f864e071..71364c6081ff 100644 >> --- a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml >> +++ b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml >> @@ -32,7 +32,7 @@ properties: >> maxItems: 1 >> >> iommus: >> - maxItems: 1 >> + maxItems: 4 >> >> power-domains: >> maxItems: 1 > > Is this a bug fix ? If yes, what about adding Fixes & Cc: stable tags ? I can do that no issue. Thanks, Michal
diff --git a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml index 9b31f864e071..71364c6081ff 100644 --- a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml +++ b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml @@ -32,7 +32,7 @@ properties: maxItems: 1 iommus: - maxItems: 1 + maxItems: 4 power-domains: maxItems: 1
Current only one entry is enabled but IP itself is using 4 different IDs which are already listed in zynqmp.dtsi. sata: ahci@fd0c0000 { compatible = "ceva,ahci-1v84"; ... iommus = <&smmu 0x4c0>, <&smmu 0x4c1>, <&smmu 0x4c2>, <&smmu 0x4c3>; }; Signed-off-by: Michal Simek <michal.simek@amd.com> --- Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)