| Message ID | 20250512084359.62178-2-cassel@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | ata: libata: Print if port is external on boot | expand |
On 5/12/25 17:44, Niklas Cassel wrote: > Commit affccb16c117 ("ata: ahci: print the lpm policy on boot") added a > lpm-pol print during boot, which shows the LPM policy used by each port. > > While the LPM policy is usually determined by the Kconfig > CONFIG_SATA_MOBILE_LPM_POLICY, the Kconfig value is overridden e.g. if > firmware has marked the port as hotplug capable / external. > > Commit f97106b10d9a ("ata: ahci: Add debug print for external port") did > add a debug print to show if LPM was disabled because firmware has marked > the port as external, however, because devices having broken LPM (even > though they claim to support it) is more common than one would have hoped, > print "ext" during boot if firmware has marked the port is external. > > This will make it easier to debug certain LPM issues, e.g. if firmware has > enabled/marked only some of the ports as hotplug capable / external. > > Before (port marked as external by firmware): > ata1: SATA max UDMA/133 abar m4096@0xfebd3000 port 0xfebd3100 irq 57 lpm-pol 0 > > After (port marked as external by firmware): > ata1: SATA max UDMA/133 abar m4096@0xfebd3000 port 0xfebd3100 irq 57 lpm-pol 0 ext > > Signed-off-by: Niklas Cassel <cassel@kernel.org> Applied to for-6.16. Thanks !
diff --git a/include/linux/libata.h b/include/linux/libata.h index 98affa1d9136..31be45fd47a6 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -1618,6 +1618,8 @@ static inline void ata_port_desc_misc(struct ata_port *ap, int irq) { ata_port_desc(ap, "irq %d", irq); ata_port_desc(ap, "lpm-pol %d", ap->target_lpm_policy); + if (ap->pflags & ATA_PFLAG_EXTERNAL) + ata_port_desc(ap, "ext"); } static inline bool ata_tag_internal(unsigned int tag)
Commit affccb16c117 ("ata: ahci: print the lpm policy on boot") added a lpm-pol print during boot, which shows the LPM policy used by each port. While the LPM policy is usually determined by the Kconfig CONFIG_SATA_MOBILE_LPM_POLICY, the Kconfig value is overridden e.g. if firmware has marked the port as hotplug capable / external. Commit f97106b10d9a ("ata: ahci: Add debug print for external port") did add a debug print to show if LPM was disabled because firmware has marked the port as external, however, because devices having broken LPM (even though they claim to support it) is more common than one would have hoped, print "ext" during boot if firmware has marked the port is external. This will make it easier to debug certain LPM issues, e.g. if firmware has enabled/marked only some of the ports as hotplug capable / external. Before (port marked as external by firmware): ata1: SATA max UDMA/133 abar m4096@0xfebd3000 port 0xfebd3100 irq 57 lpm-pol 0 After (port marked as external by firmware): ata1: SATA max UDMA/133 abar m4096@0xfebd3000 port 0xfebd3100 irq 57 lpm-pol 0 ext Signed-off-by: Niklas Cassel <cassel@kernel.org> --- include/linux/libata.h | 2 ++ 1 file changed, 2 insertions(+)