diff mbox series

[-next] ata: libata-scsi: Remove obsoleted declaration for ata_schedule_scsi_eh

Message ID 20240824121147.2521772-1-cuigaosheng1@huawei.com
State New
Headers show
Series [-next] ata: libata-scsi: Remove obsoleted declaration for ata_schedule_scsi_eh | expand

Commit Message

Gaosheng Cui Aug. 24, 2024, 12:11 p.m. UTC
The ata_schedule_scsi_eh() have been removed since
commit f8bbfc247efb ("[PATCH] SCSI: make scsi_implement_eh() generic
API for SCSI transports"), and now it is useless, so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/ata/libata.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Damien Le Moal Aug. 26, 2024, 4:08 a.m. UTC | #1
On 8/24/24 9:11 PM, Gaosheng Cui wrote:
> The ata_schedule_scsi_eh() have been removed since
> commit f8bbfc247efb ("[PATCH] SCSI: make scsi_implement_eh() generic
> API for SCSI transports"), and now it is useless, so remove it.

The path title and commit message could be better written. But see my comment
on your next patch.

> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  drivers/ata/libata.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
> index 6abf265f626e..22e667394368 100644
> --- a/drivers/ata/libata.h
> +++ b/drivers/ata/libata.h
> @@ -124,7 +124,6 @@ extern void ata_scsi_set_sense_information(struct ata_device *dev,
>  					   const struct ata_taskfile *tf);
>  extern void ata_scsi_media_change_notify(struct ata_device *dev);
>  extern void ata_scsi_hotplug(struct work_struct *work);
> -extern void ata_schedule_scsi_eh(struct Scsi_Host *shost);
>  extern void ata_scsi_dev_rescan(struct work_struct *work);
>  extern int ata_scsi_user_scan(struct Scsi_Host *shost, unsigned int channel,
>  			      unsigned int id, u64 lun);
diff mbox series

Patch

diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
index 6abf265f626e..22e667394368 100644
--- a/drivers/ata/libata.h
+++ b/drivers/ata/libata.h
@@ -124,7 +124,6 @@  extern void ata_scsi_set_sense_information(struct ata_device *dev,
 					   const struct ata_taskfile *tf);
 extern void ata_scsi_media_change_notify(struct ata_device *dev);
 extern void ata_scsi_hotplug(struct work_struct *work);
-extern void ata_schedule_scsi_eh(struct Scsi_Host *shost);
 extern void ata_scsi_dev_rescan(struct work_struct *work);
 extern int ata_scsi_user_scan(struct Scsi_Host *shost, unsigned int channel,
 			      unsigned int id, u64 lun);