diff mbox series

[v6,06/11] ata: ahci: Rephrase comment to not use the term blacklist

Message ID 20240726031954.566882-7-dlemoal@kernel.org
State New
Headers show
Series Some cleanup, renaming and horkage improvements | expand

Commit Message

Damien Le Moal July 26, 2024, 3:19 a.m. UTC
Rephrase the comment for the eMachines entry in the sysids array of
ahci_broken_suspend() to not use the term blacklist.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
 drivers/ata/ahci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Niklas Cassel July 26, 2024, 10:57 a.m. UTC | #1
On Fri, Jul 26, 2024 at 12:19:49PM +0900, Damien Le Moal wrote:
> Rephrase the comment for the eMachines entry in the sysids array of
> ahci_broken_suspend() to not use the term blacklist.
> 
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
>  drivers/ata/ahci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index a05c17249448..45f63b09828a 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1370,7 +1370,7 @@ static bool ahci_broken_suspend(struct pci_dev *pdev)
>  		 * V1.03 is known to be broken.  V3.04 is known to
>  		 * work.  Between, there are V1.06, V2.06 and V3.03
>  		 * that we don't have much idea about.  For now,
> -		 * blacklist anything older than V3.04.
> +		 * assume that anything older than V3.04 is broken.
>  		 *
>  		 * http://bugzilla.kernel.org/show_bug.cgi?id=15104
>  		 */
> -- 
> 2.45.2
> 

Reviewed-by: Niklas Cassel <cassel@kernel.org>
Igor Pylypiv July 29, 2024, 6:43 p.m. UTC | #2
On Fri, Jul 26, 2024 at 12:19:49PM +0900, Damien Le Moal wrote:
> Rephrase the comment for the eMachines entry in the sysids array of
> ahci_broken_suspend() to not use the term blacklist.
> 
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>

Reviewed-by: Igor Pylypiv <ipylypiv@google.com>

Thanks,
Igor

> ---
>  drivers/ata/ahci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index a05c17249448..45f63b09828a 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1370,7 +1370,7 @@ static bool ahci_broken_suspend(struct pci_dev *pdev)
>  		 * V1.03 is known to be broken.  V3.04 is known to
>  		 * work.  Between, there are V1.06, V2.06 and V3.03
>  		 * that we don't have much idea about.  For now,
> -		 * blacklist anything older than V3.04.
> +		 * assume that anything older than V3.04 is broken.
>  		 *
>  		 * http://bugzilla.kernel.org/show_bug.cgi?id=15104
>  		 */
> -- 
> 2.45.2
> 
>
diff mbox series

Patch

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index a05c17249448..45f63b09828a 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1370,7 +1370,7 @@  static bool ahci_broken_suspend(struct pci_dev *pdev)
 		 * V1.03 is known to be broken.  V3.04 is known to
 		 * work.  Between, there are V1.06, V2.06 and V3.03
 		 * that we don't have much idea about.  For now,
-		 * blacklist anything older than V3.04.
+		 * assume that anything older than V3.04 is broken.
 		 *
 		 * http://bugzilla.kernel.org/show_bug.cgi?id=15104
 		 */