diff mbox series

ata: pata_macio: drop driver owner assignment

Message ID 20240327174936.519861-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series ata: pata_macio: drop driver owner assignment | expand

Commit Message

Krzysztof Kozlowski March 27, 2024, 5:49 p.m. UTC
PCI core in pci_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/ata/pata_macio.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Sergey Shtylyov March 27, 2024, 6:25 p.m. UTC | #1
On 3/27/24 8:49 PM, Krzysztof Kozlowski wrote:

> PCI core in pci_register_driver() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey
Sergey Shtylyov March 27, 2024, 6:28 p.m. UTC | #2
Well, strictly speaking, it's initializer, not assignment...

MBR, Sergey
Damien Le Moal March 28, 2024, 12:17 a.m. UTC | #3
On 3/28/24 02:49, Krzysztof Kozlowski wrote:
> PCI core in pci_register_driver() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied to for-6.9-fixes. Thanks !
diff mbox series

Patch

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index 4ac854f6b057..88b2e9817f49 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1371,9 +1371,6 @@  static struct pci_driver pata_macio_pci_driver = {
 	.suspend	= pata_macio_pci_suspend,
 	.resume		= pata_macio_pci_resume,
 #endif
-	.driver = {
-		.owner		= THIS_MODULE,
-	},
 };
 MODULE_DEVICE_TABLE(pci, pata_macio_pci_match);