| Message ID | 20240311140435.34329-1-animeshagarwal28@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v7] dt-bindings: imx-pata: Convert to dtschema | expand |
On 11/03/2024 15:04, Animesh Agarwal wrote: > Convert the imx-pata bindings to DT schema. > Add missing fsl,imx31-pata and > fsl,imx51-pata compatibles during conversion, > because they are already being used in existing DTS. Thank you for improving the commit msg. It looks a bit oddly wrapped. In the future, please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 No need to resend just for this... but... > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> > > --- > Changes in v7: > - removed blank space at the end of file. > > + > +additionalProperties: false > + > +examples: > + - | > + pata: pata@83fe0000 { > + compatible = "fsl,imx51-pata","fsl,imx27-pata"; Oh my... missing space after coma, but more important: what is happening here? The space was here before in previous versions, so you removed it! At least till v4 it was correct and bam - now it is not. Why? It's the same confusing as new line appearing suddenly in v6. It looks like between each revisions of patchset some random changes appear in your code. How is it possible? Don't you work with Git? You change file, git add -p and git commit --amend. Why unrelated changes keep happening? While the actual space is a nitpick, it points to the fact that your patch experiences some changes in an unexpected way and we cannot trust that you did only what you claim in changelog. Best regards, Krzysztof
On Tue, Mar 12, 2024 at 9:55 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Thank you for improving the commit msg. It looks a bit oddly wrapped. In > the future, please wrap commit message according to Linux coding style / > submission process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 I was just trying to get the lines wrapped within 75 characters without making it harder to read. I'll follow getting line wrapped at 75 columns more strictly now. Thanks for pointing it out. > Oh my... missing space after coma, but more important: what is happening > here? The space was here before in previous versions, so you removed it! > At least till v4 it was correct and bam - now it is not. Why? It's the > same confusing as new line appearing suddenly in v6. > > It looks like between each revisions of patchset some random changes > appear in your code. How is it possible? Don't you work with Git? You > change file, git add -p and git commit --amend. Why unrelated changes > keep happening? > > While the actual space is a nitpick, it points to the fact that your > patch experiences some changes in an unexpected way and we cannot trust > that you did only what you claim in changelog. As you pointed out I indeed made a mistake at v5 by removing the space and adding a line at the end. I removed the line in v7 and didn't add the space back. I acknowledge my mistake and will be more careful. Warm regards, Animesh
diff --git a/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml new file mode 100644 index 000000000000..27b47e2d32f1 --- /dev/null +++ b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/ata/fsl,imx-pata.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale i.MX PATA Controller + +maintainers: + - Animesh Agarwal <animeshagarwal28@gmail.com> + +properties: + compatible: + oneOf: + - items: + - enum: + - fsl,imx31-pata + - fsl,imx51-pata + - const: fsl,imx27-pata + - const: fsl,imx27-pata + + reg: + maxItems: 1 + + interrupts: + items: + - description: PATA Controller interrupts + + clocks: + items: + - description: PATA Controller clocks + +additionalProperties: false + +examples: + - | + pata: pata@83fe0000 { + compatible = "fsl,imx51-pata","fsl,imx27-pata"; + reg = <0x83fe0000 0x4000>; + interrupts = <70>; + clocks = <&clks 161>; + }; diff --git a/Documentation/devicetree/bindings/ata/imx-pata.txt b/Documentation/devicetree/bindings/ata/imx-pata.txt deleted file mode 100644 index f1172f00188a..000000000000 --- a/Documentation/devicetree/bindings/ata/imx-pata.txt +++ /dev/null @@ -1,16 +0,0 @@ -* Freescale i.MX PATA Controller - -Required properties: -- compatible: "fsl,imx27-pata" -- reg: Address range of the PATA Controller -- interrupts: The interrupt of the PATA Controller -- clocks: the clocks for the PATA Controller - -Example: - - pata: pata@83fe0000 { - compatible = "fsl,imx51-pata", "fsl,imx27-pata"; - reg = <0x83fe0000 0x4000>; - interrupts = <70>; - clocks = <&clks 161>; - };
Convert the imx-pata bindings to DT schema. Add missing fsl,imx31-pata and fsl,imx51-pata compatibles during conversion, because they are already being used in existing DTS. Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> --- Changes in v7: - removed blank space at the end of file. Changes in v6: - removed items before const due to single element. Changes in v5: - added oneOf in compatible property to allow the usage of imx27 alone. Changes in v4: - added fsl,imx31-pata in compatible property as enum. Changes in v3: - added fsl,imx51-pata in compatible property as enum - fsl,imx27-pata is added as a const to ensure it is present always Changes in v2: - fixed style issues - compatible property now matches the examples - fixed yamllint warnings/errors --- .../devicetree/bindings/ata/fsl,imx-pata.yaml | 42 +++++++++++++++++++ .../devicetree/bindings/ata/imx-pata.txt | 16 ------- 2 files changed, 42 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml delete mode 100644 Documentation/devicetree/bindings/ata/imx-pata.txt