| Message ID | 20240309134810.352428-1-animeshagarwal28@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: imx-pata: Convert to dtschema | expand |
On Sat, Mar 9, 2024 at 10:48 AM Animesh <animeshagarwal28@gmail.com> wrote: > +properties: > + compatible: > + contains: > + const: fsl,imx27-pata You haven't documented fsl,imx51-pata. > +examples: > + - | > + pata: pata@83fe0000 { > + compatible = "fsl,imx51-pata", "fsl,imx27-pata"; but it is present here...
On Sat, Mar 9, 2024 at 11:44 AM Animesh Agarwal <animeshagarwal28@gmail.com> wrote: > > fsl,imx51-pata isn't present in the txt binding as well. Should i add it? Yes, you need to add it and make sure to test it with 'make dt_binding_check'.
On 09/03/2024 14:48, Animesh wrote: > Convert the imx-pata bindings to DT schema. > > Signed-off-by: Animesh <animeshagarwal28@gmail.com> Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. > --- Where is the changelog? What happened here? What changed? > .../devicetree/bindings/ata/fsl,imx-pata.yaml | 38 +++++++++++++++++++ > .../devicetree/bindings/ata/imx-pata.txt | 16 -------- > 2 files changed, 38 insertions(+), 16 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml > delete mode 100644 Documentation/devicetree/bindings/ata/imx-pata.txt > > diff --git a/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml > new file mode 100644 > index 000000000000..ee7892bf963b > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ata/fsl,imx-pata.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX PATA Controller > + > +maintainers: > + - Animesh Agarwal <animeshagarwal28@gmail.com> > + > +properties: > + compatible: > + contains: > + const: fsl,imx27-pata > + > + reg: > + maxItems: 1 > + > + interrupts: > + items: > + - description: PATA Controller interrupts > + > + clocks: > + items: > + - description: PATA Controller clocks > + > +additionalProperties: false > + > +examples: > + - | > + pata: pata@83fe0000 { > + compatible = "fsl,imx51-pata", "fsl,imx27-pata"; The same problem as before. How did you resolve test failure? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml new file mode 100644 index 000000000000..ee7892bf963b --- /dev/null +++ b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/ata/fsl,imx-pata.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale i.MX PATA Controller + +maintainers: + - Animesh Agarwal <animeshagarwal28@gmail.com> + +properties: + compatible: + contains: + const: fsl,imx27-pata + + reg: + maxItems: 1 + + interrupts: + items: + - description: PATA Controller interrupts + + clocks: + items: + - description: PATA Controller clocks + +additionalProperties: false + +examples: + - | + pata: pata@83fe0000 { + compatible = "fsl,imx51-pata", "fsl,imx27-pata"; + reg = <0x83fe0000 0x4000>; + interrupts = <70>; + clocks = <&clks 161>; + }; + diff --git a/Documentation/devicetree/bindings/ata/imx-pata.txt b/Documentation/devicetree/bindings/ata/imx-pata.txt deleted file mode 100644 index f1172f00188a..000000000000 --- a/Documentation/devicetree/bindings/ata/imx-pata.txt +++ /dev/null @@ -1,16 +0,0 @@ -* Freescale i.MX PATA Controller - -Required properties: -- compatible: "fsl,imx27-pata" -- reg: Address range of the PATA Controller -- interrupts: The interrupt of the PATA Controller -- clocks: the clocks for the PATA Controller - -Example: - - pata: pata@83fe0000 { - compatible = "fsl,imx51-pata", "fsl,imx27-pata"; - reg = <0x83fe0000 0x4000>; - interrupts = <70>; - clocks = <&clks 161>; - };
Convert the imx-pata bindings to DT schema. Signed-off-by: Animesh <animeshagarwal28@gmail.com> --- .../devicetree/bindings/ata/fsl,imx-pata.yaml | 38 +++++++++++++++++++ .../devicetree/bindings/ata/imx-pata.txt | 16 -------- 2 files changed, 38 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml delete mode 100644 Documentation/devicetree/bindings/ata/imx-pata.txt