| Message ID | 20230127093217.60818-4-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: serial/mtd/mc/ata: use MC peripheral props | expand |
On Fri, Jan 27, 2023 at 10:32 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > The re-usable serial.yaml schema matches every property with ".*" > pattern, thus any other schema referencing it will not report unknown > (unevaluated) properties. This hides several wrong properties. It is > a limitation of dtschema, thus provide a simple workaround: expect > children to be only of few names matching upstream usage (Bluetooth, > GNSS, GPS and MCU). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Fair enough, Acked-by: Linus Walleij <linus.walleij@linaro.org> However I think V.35 WAN devices (high speed serial network links) should actually be using this? They are just some fancy serial port after all. Cf Documentation/devicetree/bindings/net/intel,ixp4xx-hss.yaml No big deal I guess since they are mostly an anarchronism and not on the table right now. Yours, Linus Walleij
On 27/01/2023 14:29, Linus Walleij wrote: > On Fri, Jan 27, 2023 at 10:32 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > >> The re-usable serial.yaml schema matches every property with ".*" >> pattern, thus any other schema referencing it will not report unknown >> (unevaluated) properties. This hides several wrong properties. It is >> a limitation of dtschema, thus provide a simple workaround: expect >> children to be only of few names matching upstream usage (Bluetooth, >> GNSS, GPS and MCU). >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Fair enough, > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > However I think V.35 WAN devices (high speed serial network links) > should actually be using this? They are just some fancy serial port > after all. Cf > Documentation/devicetree/bindings/net/intel,ixp4xx-hss.yaml > > No big deal I guess since they are mostly an anarchronism and not > on the table right now. intel,ixp4xx-hss is not part of the expansion bus node. Best regards, Krzysztof
On Sun, Jan 29, 2023 at 4:48 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 27/01/2023 14:29, Linus Walleij wrote: > > On Fri, Jan 27, 2023 at 10:32 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > > > >> The re-usable serial.yaml schema matches every property with ".*" > >> pattern, thus any other schema referencing it will not report unknown > >> (unevaluated) properties. This hides several wrong properties. It is > >> a limitation of dtschema, thus provide a simple workaround: expect > >> children to be only of few names matching upstream usage (Bluetooth, > >> GNSS, GPS and MCU). > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Fair enough, > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > However I think V.35 WAN devices (high speed serial network links) > > should actually be using this? They are just some fancy serial port > > after all. Cf > > Documentation/devicetree/bindings/net/intel,ixp4xx-hss.yaml > > > > No big deal I guess since they are mostly an anarchronism and not > > on the table right now. > > intel,ixp4xx-hss is not part of the expansion bus node. True, my point is that WAN V.35 devices in general should be, so that the pattern properties should include wan. But we can add it later if a user appears. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml index e05ad3ac2abc..c9231e501f1f 100644 --- a/Documentation/devicetree/bindings/serial/serial.yaml +++ b/Documentation/devicetree/bindings/serial/serial.yaml @@ -96,7 +96,7 @@ then: rts-gpios: false patternProperties: - ".*": + "^bluetooth|gnss|gps|mcu$": if: type: object then:
The re-usable serial.yaml schema matches every property with ".*" pattern, thus any other schema referencing it will not report unknown (unevaluated) properties. This hides several wrong properties. It is a limitation of dtschema, thus provide a simple workaround: expect children to be only of few names matching upstream usage (Bluetooth, GNSS, GPS and MCU). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/serial/serial.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)