| Message ID | 20220726170108.25087-1-thenzl@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | libata: specify timeout value when internal command times out. | expand |
Hello! On 7/26/22 8:01 PM, Tomas Henzl wrote: > Specifying timeout value may help in troubleshooting failures. > > Signed-off-by: David Milburn <dmilburn@redhat.com> > Signed-off-by: Tomas Henzl <thenzl@redhat.com> > --- > drivers/ata/libata-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 40e816419f48..e1f8a01a3b92 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -1578,8 +1578,8 @@ unsigned ata_exec_internal_sg(struct ata_device *dev, > else > ata_qc_complete(qc); > > - ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n", > - command); > + ata_dev_warn(dev, "qc timeout after %lu msecs (cmd 0x%x)\n", > + timeout, command); The 'timeout' parameter is now *unsigned int*, please generate the patches against the libata repo's for-next branch. [...] MBR, Sergey
On 7/26/22 19:36, Sergei Shtylyov wrote: > Hello! > > On 7/26/22 8:01 PM, Tomas Henzl wrote: > >> Specifying timeout value may help in troubleshooting failures. >> >> Signed-off-by: David Milburn <dmilburn@redhat.com> >> Signed-off-by: Tomas Henzl <thenzl@redhat.com> >> --- >> drivers/ata/libata-core.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c >> index 40e816419f48..e1f8a01a3b92 100644 >> --- a/drivers/ata/libata-core.c >> +++ b/drivers/ata/libata-core.c >> @@ -1578,8 +1578,8 @@ unsigned ata_exec_internal_sg(struct ata_device *dev, >> else >> ata_qc_complete(qc); >> >> - ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n", >> - command); >> + ata_dev_warn(dev, "qc timeout after %lu msecs (cmd 0x%x)\n", >> + timeout, command); > The 'timeout' parameter is now *unsigned int*, please generate the patches > against the libata repo's for-next branch. ok, thanks, will do > > [...] > > MBR, Sergey >
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 40e816419f48..e1f8a01a3b92 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -1578,8 +1578,8 @@ unsigned ata_exec_internal_sg(struct ata_device *dev, else ata_qc_complete(qc); - ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n", - command); + ata_dev_warn(dev, "qc timeout after %lu msecs (cmd 0x%x)\n", + timeout, command); } spin_unlock_irqrestore(ap->lock, flags);