| Message ID | 20220323054001.17344-1-diego.viola@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ata: libata-core: fix "it's" typos | expand |
On 3/23/22 14:40, Diego Viola wrote: > Use the contraction "it's" instead of the possessive form "its". Well, while at it, let's use proper formal written English, so: s/it's/it is s/isn't/is not > > Signed-off-by: Diego Viola <diego.viola@gmail.com> > --- > drivers/ata/libata-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 0c854aebfe0b..22c93589f2c4 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -1398,7 +1398,7 @@ unsigned long ata_id_xfermask(const u16 *id) > > /* But wait.. there's more. Design your standards by > * committee and you too can get a free iordy field to > - * process. However its the speeds not the modes that > + * process. However it's the speeds not the modes that > * are supported... Note drivers using the timing API > * will get this right anyway > */ > @@ -5603,7 +5603,7 @@ static void ata_finalize_port_ops(struct ata_port_operations *ops) > * Start and then freeze ports of @host. Started status is > * recorded in host->flags, so this function can be called > * multiple times. Ports are guaranteed to get started only > - * once. If host->ops isn't initialized yet, its set to the > + * once. If host->ops isn't initialized yet, it's set to the > * first non-dummy port ops. > * > * LOCKING:
On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote: > > On 3/23/22 14:40, Diego Viola wrote: > > Use the contraction "it's" instead of the possessive form "its". > > Well, while at it, let's use proper formal written English, so: > s/it's/it is > s/isn't/is not Fine with me, do you want me to send you another patch with those changes? Regards, Diego
On 3/23/22 14:52, Diego Viola wrote: > On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal > <damien.lemoal@opensource.wdc.com> wrote: >> >> On 3/23/22 14:40, Diego Viola wrote: >>> Use the contraction "it's" instead of the possessive form "its". >> >> Well, while at it, let's use proper formal written English, so: >> s/it's/it is >> s/isn't/is not > > Fine with me, do you want me to send you another patch with those changes? Yes please. > > Regards, > Diego
On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote: > > On 3/23/22 14:52, Diego Viola wrote: > > On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal > > <damien.lemoal@opensource.wdc.com> wrote: > >> > >> On 3/23/22 14:40, Diego Viola wrote: > >>> Use the contraction "it's" instead of the possessive form "its". > >> > >> Well, while at it, let's use proper formal written English, so: > >> s/it's/it is > >> s/isn't/is not > > > > Fine with me, do you want me to send you another patch with those changes? > > Yes please. I sent a v2 patch changing those things you pointed out, however, the whole comment[0] looks informal "But wait.. there's more" and I don't think replacing "it's" with "it is" achieves a lot in this case. [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/ata/libata-core.c#n1399 Diego
On 3/23/22 16:24, Diego Viola wrote: > On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal > <damien.lemoal@opensource.wdc.com> wrote: >> >> On 3/23/22 14:52, Diego Viola wrote: >>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal >>> <damien.lemoal@opensource.wdc.com> wrote: >>>> >>>> On 3/23/22 14:40, Diego Viola wrote: >>>>> Use the contraction "it's" instead of the possessive form "its". >>>> >>>> Well, while at it, let's use proper formal written English, so: >>>> s/it's/it is >>>> s/isn't/is not >>> >>> Fine with me, do you want me to send you another patch with those changes? >> >> Yes please. > > I sent a v2 patch changing those things you pointed out, however, the > whole comment[0] looks informal "But wait.. there's more" and I don't > think replacing "it's" with "it is" achieves a lot in this case. :) Indeed. Do you want it in or can I drop it ? > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/ata/libata-core.c#n1399 > > Diego
On Wed, Mar 23, 2022 at 5:17 AM Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote: > > On 3/23/22 16:24, Diego Viola wrote: > > On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal > > <damien.lemoal@opensource.wdc.com> wrote: > >> > >> On 3/23/22 14:52, Diego Viola wrote: > >>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal > >>> <damien.lemoal@opensource.wdc.com> wrote: > >>>> > >>>> On 3/23/22 14:40, Diego Viola wrote: > >>>>> Use the contraction "it's" instead of the possessive form "its". > >>>> > >>>> Well, while at it, let's use proper formal written English, so: > >>>> s/it's/it is > >>>> s/isn't/is not > >>> > >>> Fine with me, do you want me to send you another patch with those changes? > >> > >> Yes please. > > > > I sent a v2 patch changing those things you pointed out, however, the > > whole comment[0] looks informal "But wait.. there's more" and I don't > > think replacing "it's" with "it is" achieves a lot in this case. > > :) > > Indeed. Do you want it in or can I drop it ? Given that the language is mostly informal, I'd rather see the first patch applied (if that is OK with you). However, I agree with you that it would be nice to see formal language used, I just don't think I'm the right person to change all the comments in that file. :( Thanks, Diego
On 3/23/22 17:44, Diego Viola wrote: > On Wed, Mar 23, 2022 at 5:17 AM Damien Le Moal > <damien.lemoal@opensource.wdc.com> wrote: >> >> On 3/23/22 16:24, Diego Viola wrote: >>> On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal >>> <damien.lemoal@opensource.wdc.com> wrote: >>>> >>>> On 3/23/22 14:52, Diego Viola wrote: >>>>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal >>>>> <damien.lemoal@opensource.wdc.com> wrote: >>>>>> >>>>>> On 3/23/22 14:40, Diego Viola wrote: >>>>>>> Use the contraction "it's" instead of the possessive form "its". >>>>>> >>>>>> Well, while at it, let's use proper formal written English, so: >>>>>> s/it's/it is >>>>>> s/isn't/is not >>>>> >>>>> Fine with me, do you want me to send you another patch with those changes? >>>> >>>> Yes please. >>> >>> I sent a v2 patch changing those things you pointed out, however, the >>> whole comment[0] looks informal "But wait.. there's more" and I don't >>> think replacing "it's" with "it is" achieves a lot in this case. >> >> :) >> >> Indeed. Do you want it in or can I drop it ? > > Given that the language is mostly informal, I'd rather see the first > patch applied (if that is OK with you). However, I agree with you that > it would be nice to see formal language used, I just don't think I'm > the right person to change all the comments in that file. :( OK. I will look at it. > > Thanks, > Diego
On Thu, Mar 24, 2022 at 1:14 AM Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote: > > On 3/23/22 17:44, Diego Viola wrote: > > On Wed, Mar 23, 2022 at 5:17 AM Damien Le Moal > > <damien.lemoal@opensource.wdc.com> wrote: > >> > >> On 3/23/22 16:24, Diego Viola wrote: > >>> On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal > >>> <damien.lemoal@opensource.wdc.com> wrote: > >>>> > >>>> On 3/23/22 14:52, Diego Viola wrote: > >>>>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal > >>>>> <damien.lemoal@opensource.wdc.com> wrote: > >>>>>> > >>>>>> On 3/23/22 14:40, Diego Viola wrote: > >>>>>>> Use the contraction "it's" instead of the possessive form "its". > >>>>>> > >>>>>> Well, while at it, let's use proper formal written English, so: > >>>>>> s/it's/it is > >>>>>> s/isn't/is not > >>>>> > >>>>> Fine with me, do you want me to send you another patch with those changes? > >>>> > >>>> Yes please. > >>> > >>> I sent a v2 patch changing those things you pointed out, however, the > >>> whole comment[0] looks informal "But wait.. there's more" and I don't > >>> think replacing "it's" with "it is" achieves a lot in this case. > >> > >> :) > >> > >> Indeed. Do you want it in or can I drop it ? > > > > Given that the language is mostly informal, I'd rather see the first > > patch applied (if that is OK with you). However, I agree with you that > > it would be nice to see formal language used, I just don't think I'm > > the right person to change all the comments in that file. :( > > OK. I will look at it. OK, thank you. > > > > > Thanks, > > Diego > > > -- > Damien Le Moal > Western Digital Research Diego
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 0c854aebfe0b..22c93589f2c4 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -1398,7 +1398,7 @@ unsigned long ata_id_xfermask(const u16 *id) /* But wait.. there's more. Design your standards by * committee and you too can get a free iordy field to - * process. However its the speeds not the modes that + * process. However it's the speeds not the modes that * are supported... Note drivers using the timing API * will get this right anyway */ @@ -5603,7 +5603,7 @@ static void ata_finalize_port_ops(struct ata_port_operations *ops) * Start and then freeze ports of @host. Started status is * recorded in host->flags, so this function can be called * multiple times. Ports are guaranteed to get started only - * once. If host->ops isn't initialized yet, its set to the + * once. If host->ops isn't initialized yet, it's set to the * first non-dummy port ops. * * LOCKING:
Use the contraction "it's" instead of the possessive form "its". Signed-off-by: Diego Viola <diego.viola@gmail.com> --- drivers/ata/libata-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)