| Message ID | 20211224131300.18198-9-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,01/10] ata: pata_platform: Make use of platform_get_mem_or_io() | expand |
Hm, this ended up in my spam folder... :-( On 12/24/21 4:12 PM, Lad Prabhakar wrote: > Drop validating num_resources count as pata_platform_get_resources() > already does this check for us. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> [...] Good patch but should have been placed before patch #7... Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> MBR, Sergey
diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c index 4273f1a9abd2..88a9bdc81e68 100644 --- a/drivers/ata/pata_platform.c +++ b/drivers/ata/pata_platform.c @@ -265,14 +265,6 @@ static int pata_platform_get_pdata(struct platform_device *pdev, struct pata_platform_info *pp_info = dev_get_platdata(&pdev->dev); int ret; - /* - * Simple resource validation .. - */ - if ((pdev->num_resources != 3) && (pdev->num_resources != 2)) { - dev_err(&pdev->dev, "invalid number of resources\n"); - return -EINVAL; - } - ret = pata_platform_get_resources(pdev, priv); if (ret) return ret;
Drop validating num_resources count as pata_platform_get_resources() already does this check for us. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- v2-->v3 * New patch --- drivers/ata/pata_platform.c | 8 -------- 1 file changed, 8 deletions(-)