From patchwork Fri Dec 24 13:12:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lad Prabhakar X-Patchwork-Id: 1573037 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4JL6ty2TBPz9sPC for ; Sat, 25 Dec 2021 00:13:14 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352744AbhLXNNM (ORCPT ); Fri, 24 Dec 2021 08:13:12 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:53177 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1352735AbhLXNNJ (ORCPT ); Fri, 24 Dec 2021 08:13:09 -0500 X-IronPort-AV: E=Sophos;i="5.88,232,1635174000"; d="scan'208";a="105104958" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 24 Dec 2021 22:13:08 +0900 Received: from localhost.localdomain (unknown [10.226.36.204]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 6E84243A1818; Fri, 24 Dec 2021 22:13:07 +0900 (JST) From: Lad Prabhakar To: Damien Le Moal Cc: Sergey Shtylyov , Rob Herring , linux-kernel@vger.kernel.org, Prabhakar , Lad Prabhakar , linux-ide@vger.kernel.org Subject: [PATCH v3 02/10] ata: pata_platform: Drop use of unlikely() in pata_platform_probe Date: Fri, 24 Dec 2021 13:12:51 +0000 Message-Id: <20211224131300.18198-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211224131300.18198-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20211224131300.18198-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org pata_platform_probe() isn't a hotpath, which makes it's questionable to use unlikely(). Therefore let's simply drop it. Signed-off-by: Lad Prabhakar --- v2-->v3 * New patch --- drivers/ata/pata_platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c index cb3134bf88eb..29902001e223 100644 --- a/drivers/ata/pata_platform.c +++ b/drivers/ata/pata_platform.c @@ -199,14 +199,14 @@ static int pata_platform_probe(struct platform_device *pdev) * Get the I/O base first */ io_res = platform_get_mem_or_io(pdev, 0); - if (unlikely(!io_res)) + if (!io_res) return -EINVAL; /* * Then the CTL base */ ctl_res = platform_get_mem_or_io(pdev, 1); - if (unlikely(!ctl_res)) + if (!ctl_res) return -EINVAL; /*