| Message ID | 20211217112832.69875-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/1] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved | expand |
On 12/17/21 20:28, Andy Shevchenko wrote: > platform_get_irq() will print a message when it fails. > No need to repeat this. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v2: left !irq check untouched (Damien, Sergey) > drivers/ata/libahci_platform.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c > index bfa267e6f045..18296443ccba 100644 > --- a/drivers/ata/libahci_platform.c > +++ b/drivers/ata/libahci_platform.c > @@ -579,11 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev, > int i, irq, n_ports, rc; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - if (irq != -EPROBE_DEFER) > - dev_err(dev, "no irq\n"); > + if (irq < 0) > return irq; > - } > if (!irq) > return -EINVAL; > Applied to for-5.17. Thanks !
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c index bfa267e6f045..18296443ccba 100644 --- a/drivers/ata/libahci_platform.c +++ b/drivers/ata/libahci_platform.c @@ -579,11 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev, int i, irq, n_ports, rc; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - if (irq != -EPROBE_DEFER) - dev_err(dev, "no irq\n"); + if (irq < 0) return irq; - } if (!irq) return -EINVAL;
platform_get_irq() will print a message when it fails. No need to repeat this. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: left !irq check untouched (Damien, Sergey) drivers/ata/libahci_platform.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)