diff mbox series

[v2,2/2] ide: Remove BUG_ON(in_interrupt() || irqs_disabled()) from ide_unregister()

Message ID 20201120092421.1023428-3-bigeasy@linutronix.de
State New
Headers show
Series ide: Remove in_interrupt(). | expand

Commit Message

Sebastian Andrzej Siewior Nov. 20, 2020, 9:24 a.m. UTC
Both BUG_ON() were introduced in commit
   4015c949fb465 ("[PATCH] update ide core")

when ide_unregister() was extended with semaphore based locking. Both
checks won't complain about disabled preemption which is also wrong.

The might_sleep() in today's mutex_lock() will complain about the

Remove the BUG_ON() statements.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Jens Axboe <axboe@kernel.dk>
 drivers/ide/ide-probe.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series


diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 1c1567bb51942..aefd74c0d8628 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -1539,9 +1539,6 @@  EXPORT_SYMBOL_GPL(ide_port_unregister_devices);
 static void ide_unregister(ide_hwif_t *hwif)
-	BUG_ON(in_interrupt());
-	BUG_ON(irqs_disabled());
 	if (hwif->present) {