[10/19] paride/pcd: use bdev_check_media_change

Message ID	20200908145347.2992670-11-hch@lst.de
State	Not Applicable
Delegated to:	David Miller
Headers	show Return-Path: <linux-ide-owner@vger.kernel.org> From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@kernel.dk> Cc: Denis Efremov <efremov@linux.com>, Tim Waugh <tim@cyberelk.net>, Michal Simek <michal.simek@xilinx.com>, Borislav Petkov <bp@alien8.de>, "David S. Miller" <davem@davemloft.net>, Song Liu <song@kernel.org>, "Martin K. Petersen" <martin.petersen@oracle.com>, Finn Thain <fthain@telegraphics.com.au>, Michael Schmitz <schmitzmic@gmail.com>, linux-m68k@lists.linux-m68k.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, Johannes Thumshirn <johannes.thumshirn@wdc.com> Subject: [PATCH 10/19] paride/pcd: use bdev_check_media_change Date: Tue, 8 Sep 2020 16:53:38 +0200 Message-Id: <20200908145347.2992670-11-hch@lst.de> In-Reply-To: <20200908145347.2992670-1-hch@lst.de> References: <20200908145347.2992670-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-ide-owner@vger.kernel.org Precedence: bulk
Series	[01/19] block: add a bdev_check_media_change helper \| expand [01/19] block: add a bdev_check_media_change helper [02/19] amiflop: use bdev_check_media_change [03/19] ataflop: use bdev_check_media_change [04/19] floppy: use bdev_check_media_change [05/19] swim: use bdev_check_media_change [06/19] swim: simplify media change handling [07/19] swim3: use bdev_check_media_changed [08/19] xsysace: use bdev_check_media_change [09/19] xsysace: simplify media change handling [10/19] paride/pcd: use bdev_check_media_change [11/19] gdrom: use bdev_check_media_change [12/19] ide-cd: use bdev_check_media_changed [13/19] ide-cd: remove idecd_revalidate_disk [14/19] ide-gd: stop using the disk events mechanism [15/19] md: use bdev_check_media_change [16/19] sd: use bdev_check_media_change [17/19] sr: use bdev_check_media_change [18/19] sr: simplify sr_block_revalidate_disk [19/19] block: remove check_disk_change

Message ID

20200908145347.2992670-11-hch@lst.de

State

Not Applicable

Delegated to:

David Miller

Headers

From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Denis Efremov <efremov@linux.com>, Tim Waugh <tim@cyberelk.net>,
        Michal Simek <michal.simek@xilinx.com>,
        Borislav Petkov <bp@alien8.de>,
        "David S. Miller" <davem@davemloft.net>,
        Song Liu <song@kernel.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Finn Thain <fthain@telegraphics.com.au>,
        Michael Schmitz <schmitzmic@gmail.com>,
        linux-m68k@lists.linux-m68k.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
        linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-fsdevel@vger.kernel.org,
        Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 10/19] paride/pcd: use bdev_check_media_change
Date: Tue,  8 Sep 2020 16:53:38 +0200
Message-Id: <20200908145347.2992670-11-hch@lst.de>
In-Reply-To: <20200908145347.2992670-1-hch@lst.de>
References: <20200908145347.2992670-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-ide-owner@vger.kernel.org
Precedence: bulk

Series

[01/19] block: add a bdev_check_media_change helper | expand

Commit Message

Christoph Hellwig Sept. 8, 2020, 2:53 p.m. UTC

The pcd driver does not have a ->revalidate_disk method, so it can just
use bdev_check_media_change without any additional changes.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 drivers/block/paride/pcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hannes Reinecke Sept. 9, 2020, 7:26 a.m. UTC | #1

On 9/8/20 4:53 PM, Christoph Hellwig wrote:
> The pcd driver does not have a ->revalidate_disk method, so it can just
> use bdev_check_media_change without any additional changes.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
>  drivers/block/paride/pcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
> index 5124eca90e8337..70da8b86ce587d 100644
> --- a/drivers/block/paride/pcd.c
> +++ b/drivers/block/paride/pcd.c
> @@ -233,7 +233,7 @@ static int pcd_block_open(struct block_device *bdev, fmode_t mode)
>  	struct pcd_unit *cd = bdev->bd_disk->private_data;
>  	int ret;
>  
> -	check_disk_change(bdev);
> +	bdev_check_media_change(bdev);
>  
>  	mutex_lock(&pcd_mutex);
>  	ret = cdrom_open(&cd->info, bdev, mode);
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes

diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
index 5124eca90e8337..70da8b86ce587d 100644
--- a/drivers/block/paride/pcd.c
+++ b/drivers/block/paride/pcd.c
@@ -233,7 +233,7 @@  static int pcd_block_open(struct block_device *bdev, fmode_t mode)
 	struct pcd_unit *cd = bdev->bd_disk->private_data;
 	int ret;
 
-	check_disk_change(bdev);
+	bdev_check_media_change(bdev);
 
 	mutex_lock(&pcd_mutex);
 	ret = cdrom_open(&cd->info, bdev, mode);

[10/19] paride/pcd: use bdev_check_media_change

Commit Message

Comments

Patch