| Message ID | 20190429152209.22851-1-geert+renesas@glider.be |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | sata_rcar: Remove ata_host_alloc() error printing | expand |
On 29.04.2019 18:22, Geert Uytterhoeven wrote: > ata_host_alloc() can only fail due to memory allocation failures. > Hence there is no need to print a message, as the memory allocation core > code already takes care of that. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> [...] MBR, Sergei
On Mon, Apr 29, 2019 at 05:22:09PM +0200, Geert Uytterhoeven wrote: > ata_host_alloc() can only fail due to memory allocation failures. > Hence there is no need to print a message, as the memory allocation core > code already takes care of that. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Jens, could you consider picking this one up? > --- > drivers/ata/sata_rcar.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c > index 59b2317acea99e46..3495e1733a8e6756 100644 > --- a/drivers/ata/sata_rcar.c > +++ b/drivers/ata/sata_rcar.c > @@ -909,7 +909,6 @@ static int sata_rcar_probe(struct platform_device *pdev) > > host = ata_host_alloc(dev, 1); > if (!host) { > - dev_err(dev, "ata_host_alloc failed\n"); > ret = -ENOMEM; > goto err_pm_put; > } > -- > 2.17.1 >
On 4/29/19 9:22 AM, Geert Uytterhoeven wrote: > ata_host_alloc() can only fail due to memory allocation failures. > Hence there is no need to print a message, as the memory allocation core > code already takes care of that. Applied, thanks.
diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c index 59b2317acea99e46..3495e1733a8e6756 100644 --- a/drivers/ata/sata_rcar.c +++ b/drivers/ata/sata_rcar.c @@ -909,7 +909,6 @@ static int sata_rcar_probe(struct platform_device *pdev) host = ata_host_alloc(dev, 1); if (!host) { - dev_err(dev, "ata_host_alloc failed\n"); ret = -ENOMEM; goto err_pm_put; }
ata_host_alloc() can only fail due to memory allocation failures. Hence there is no need to print a message, as the memory allocation core code already takes care of that. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/ata/sata_rcar.c | 1 - 1 file changed, 1 deletion(-)