From patchwork Wed May 9 00:28:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 910578 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="PAiZOfNw"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40gcdv01Rdz9s3G for ; Wed, 9 May 2018 10:28:19 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932965AbeEIA2R (ORCPT ); Tue, 8 May 2018 20:28:17 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:25942 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932475AbeEIA2R (ORCPT ); Tue, 8 May 2018 20:28:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1525825697; x=1557361697; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=Z830XQubWuSgbi2SZ3OrQwfYxkJGO1X1RLmDxxm1o5c=; b=PAiZOfNwxLNG2dbtHMwd45NX2S9TgDyPDzjjb8IiWLKwFgFeh2aOMkmB 6aMU6hJGu4cZT5rCHWmopy1fXSiyODVpVW2VWmnP0mI+OcQH/Xx/UnEiO UZnT4+tTeA6vWfzBnL4JYiIEYdlyOFZzOBBmgiJjWng61SUKeSQvpSrnc I3Xkg01uLF4zXb0lK8/f1RU+se/lnznKKDPNvyiMhEucCKtvVB4QSqZfW XdA51WwoneeT1fKsjdX+u2dBh4yKV5rX2QqyENaObOyvphlZilghFQirp kH7UUs0W5rD/R1rk9bVBk76hk1haTEnXlc0X4mNK0bO4rw6RCknPxKDnw w==; X-IronPort-AV: E=Sophos;i="5.49,379,1520870400"; d="scan'208";a="180758039" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 09 May 2018 08:28:17 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP; 08 May 2018 17:19:56 -0700 Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip01.wdc.com with ESMTP; 08 May 2018 17:28:16 -0700 From: Damien Le Moal To: linux-ide@vger.kernel.org, Tejun Heo Cc: "Martin K . Petersen" , Hannes Reinecke , Bart Van Assche Subject: [PATCH 3/5] libata: Make ata_dev_set_mode() less verbose Date: Wed, 9 May 2018 09:28:10 +0900 Message-Id: <20180509002812.13151-4-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180509002812.13151-1-damien.lemoal@wdc.com> References: <20180509002812.13151-1-damien.lemoal@wdc.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org For a successful setting of the device transfer speed mode in ata_dev_set_mode(), do not print the message "ataX.XX: configured for xxx" if the EH context has the quiet flag set, unless the device port is being reset. This preserves the output of the message during device scan but removes it in the case of a simple device revalidation such as trigerred by enabling the NCQ I/O priority feature of the device e.g. echo 1 > /sys/block/sdxx/device/ncq_iprio_enable Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke --- drivers/ata/libata-core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 68596bd4cf06..f65c62bff229 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3573,9 +3573,11 @@ static int ata_dev_set_mode(struct ata_device *dev) DPRINTK("xfer_shift=%u, xfer_mode=0x%x\n", dev->xfer_shift, (int)dev->xfer_mode); - ata_dev_info(dev, "configured for %s%s\n", - ata_mode_string(ata_xfer_mode2mask(dev->xfer_mode)), - dev_err_whine); + if (!(ehc->i.flags & ATA_EHI_QUIET) || + ehc->i.flags & ATA_EHI_DID_HARDRESET) + ata_dev_info(dev, "configured for %s%s\n", + ata_mode_string(ata_xfer_mode2mask(dev->xfer_mode)), + dev_err_whine); return 0;