From patchwork Fri May 4 14:24:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 908778 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linutronix.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40cvSQ6s2Rz9s3D for ; Sat, 5 May 2018 00:25:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751652AbeEDOZO (ORCPT ); Fri, 4 May 2018 10:25:14 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:40841 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbeEDOZM (ORCPT ); Fri, 4 May 2018 10:25:12 -0400 Received: from localhost ([127.0.0.1] helo=bazinga.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1fEbe0-0005Vc-OB; Fri, 04 May 2018 16:25:09 +0200 From: Sebastian Andrzej Siewior To: linux-ide@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, "David S. Miller" , Sebastian Andrzej Siewior Subject: [PATCH 1/4] alim15x3: move irq-restore before pci_dev_put() Date: Fri, 4 May 2018 16:24:43 +0200 Message-Id: <20180504142446.30525-2-bigeasy@linutronix.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180504142446.30525-1-bigeasy@linutronix.de> References: <20180504142446.30525-1-bigeasy@linutronix.de> MIME-Version: 1.0 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org init_chipset_ali15x3() initializes the chipset during init with disabled interrupts. There is no need to keep the interrupts disabled during pci_dev_put(). Move the irq-restore before pci_dev_put() is invoked. Side note: The same init is performed in drivers/ata/pata_ali.c::ali_init_chipset() without disabled interrupts. It looks that the same hardware is supported in the ATA land. Would it make sense to remove this driver since it is supported in the other subsystem? Signed-off-by: Sebastian Andrzej Siewior Acked-by: David S. Miller --- drivers/ide/alim15x3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/alim15x3.c b/drivers/ide/alim15x3.c index 36f76e28a0bf..3265970aee34 100644 --- a/drivers/ide/alim15x3.c +++ b/drivers/ide/alim15x3.c @@ -323,9 +323,9 @@ static int init_chipset_ali15x3(struct pci_dev *dev) pci_write_config_byte(dev, 0x53, tmpbyte); } + local_irq_restore(flags); pci_dev_put(north); pci_dev_put(isa_dev); - local_irq_restore(flags); return 0; }