Message ID | 20140722132800.952BA60250@zebedee.buttersideup.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Tue, Jul 22, 2014 at 02:28:00PM +0100, Tim Small wrote: > In machines with multiple Silicon Image 3124 and/or 3132 cards, there is no > way to tell which card is the culprit when the sata_sil24 interrupt handler > gets a bad status. > > Tested-by: tim@seoss.co.uk > Signed-off-by: tim@seoss.co.uk Applied to libata/for-3.17. Please use "Full Name <EMAIL>" for tags. Thanks.
Hello. On 07/22/2014 05:28 PM, Tim Small wrote: > In machines with multiple Silicon Image 3124 and/or 3132 cards, there is no > way to tell which card is the culprit when the sata_sil24 interrupt handler > gets a bad status. > Tested-by: tim@seoss.co.uk > Signed-off-by: tim@seoss.co.uk Full name is required before email, and email should be enclosed in <>. Also, I guess you want the same email as the commit author and in the signoff? Use the From: line at the start of mail to override the one in the header. See Documentation/SubmittingPatches for more details... [...] > diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c > index 0534890..d81b20d 100644 > --- a/drivers/ata/sata_sil24.c > +++ b/drivers/ata/sata_sil24.c > @@ -1154,8 +1154,8 @@ static irqreturn_t sil24_interrupt(int irq, void *dev_instance) > status = readl(host_base + HOST_IRQ_STAT); > > if (status == 0xffffffff) { > - printk(KERN_ERR DRV_NAME ": IRQ status == 0xffffffff, " > - "PCI fault or device removal?\n"); > + dev_err(host->dev, "IRQ status == 0xffffffff, " > + "PCI fault or device removal?\n"); Don't break the string anymore please. I guess you haven't run the patch thru scripts/checkpatch.pl? > goto out; > } WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c index 0534890..d81b20d 100644 --- a/drivers/ata/sata_sil24.c +++ b/drivers/ata/sata_sil24.c @@ -1154,8 +1154,8 @@ static irqreturn_t sil24_interrupt(int irq, void *dev_instance) status = readl(host_base + HOST_IRQ_STAT); if (status == 0xffffffff) { - printk(KERN_ERR DRV_NAME ": IRQ status == 0xffffffff, " - "PCI fault or device removal?\n"); + dev_err(host->dev, "IRQ status == 0xffffffff, " + "PCI fault or device removal?\n"); goto out; }