Message ID | 20130117182239.GA31009@dhcp-10-15-1-70.hsv.redhat.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Thu, Jan 17, 2013 at 7:22 PM, David Milburn <dmilburn@redhat.com> wrote: > The port multiplier extends the ATA port with up to 15 additional ports (links), > so with this patch > > ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata1 > ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata1/link1/dev1.0/ata_device > ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata1/link1/ata_link > ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata1/link1.0/dev1.0.0/ata_device > ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata1/link1.0/ata_link > ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata1/link1.1/dev1.1.0/ata_device > ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata1/link1.1/ata_link > > ata<localport>/link<localport>.<unique port mult port>/dev<localport>.<port mult port>.0/ata_device @@ -284,7 +284,7 @@ int ata_tport_add(struct device *parent, dev->parent = get_device(parent); dev->release = ata_tport_release; - dev_set_name(dev, "ata%d", ap->print_id); + dev_set_name(dev, "ata%d", ap->local_print_id); > @@ -410,9 +410,9 @@ int ata_tlink_add(struct ata_link *link) > dev->parent = get_device(&ap->tdev); > dev->release = ata_tlink_release; > if (ata_is_host_link(link)) > - dev_set_name(dev, "link%d", ap->print_id); > + dev_set_name(dev, "link%d", ap->local_print_id); Hmm, multiple controllers will clash with their names here now, right? The "ata%d" and "link%d..." devices all show up in /sys/class/ in the same directories and need a unique name there, now that we start at every controller with out own counter, right? We need to prefix the names with the global counter? Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 9e8b99a..b225b87 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5604,6 +5604,7 @@ struct ata_port *ata_port_alloc(struct ata_host *host) ap->pflags |= ATA_PFLAG_INITIALIZING | ATA_PFLAG_FROZEN; ap->lock = &host->lock; ap->print_id = -1; + ap->local_print_id = -1; ap->host = host; ap->dev = host->dev; @@ -6094,9 +6095,10 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht) kfree(host->ports[i]); /* give ports names and add SCSI hosts */ - for (i = 0; i < host->n_ports; i++) + for (i = 0; i < host->n_ports; i++) { host->ports[i]->print_id = atomic_inc_return(&ata_print_id); - + host->ports[i]->local_print_id = i + 1; + } /* Create associated sysfs transport objects */ for (i = 0; i < host->n_ports; i++) { diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c index c04d393..7f6feaf 100644 --- a/drivers/ata/libata-transport.c +++ b/drivers/ata/libata-transport.c @@ -284,7 +284,7 @@ int ata_tport_add(struct device *parent, dev->parent = get_device(parent); dev->release = ata_tport_release; - dev_set_name(dev, "ata%d", ap->print_id); + dev_set_name(dev, "ata%d", ap->local_print_id); transport_setup_device(dev); error = device_add(dev); if (error) { @@ -410,9 +410,9 @@ int ata_tlink_add(struct ata_link *link) dev->parent = get_device(&ap->tdev); dev->release = ata_tlink_release; if (ata_is_host_link(link)) - dev_set_name(dev, "link%d", ap->print_id); + dev_set_name(dev, "link%d", ap->local_print_id); else - dev_set_name(dev, "link%d.%d", ap->print_id, link->pmp); + dev_set_name(dev, "link%d.%d", ap->local_print_id, link->pmp); transport_setup_device(dev); @@ -638,9 +638,9 @@ static int ata_tdev_add(struct ata_device *ata_dev) dev->parent = get_device(&link->tdev); dev->release = ata_tdev_release; if (ata_is_host_link(link)) - dev_set_name(dev, "dev%d.%d", ap->print_id,ata_dev->devno); + dev_set_name(dev, "dev%d.%d", ap->local_print_id,ata_dev->devno); else - dev_set_name(dev, "dev%d.%d.0", ap->print_id, link->pmp); + dev_set_name(dev, "dev%d.%d.0", ap->local_print_id, link->pmp); transport_setup_device(dev); error = device_add(dev); diff --git a/include/linux/libata.h b/include/linux/libata.h index 83ba0ab..5208532 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -742,6 +742,7 @@ struct ata_port { /* Flags that change dynamically, protected by ap->lock */ unsigned int pflags; /* ATA_PFLAG_xxx */ unsigned int print_id; /* user visible unique port ID */ + unsigned int local_print_id; /* host local port ID */ unsigned int port_no; /* 0 based port no. inside the host */ #ifdef CONFIG_ATA_SFF