From patchwork Thu Apr 7 16:54:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Herrmann X-Patchwork-Id: 90210 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 14C40B6F74 for ; Fri, 8 Apr 2011 02:54:17 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913Ab1DGQyP (ORCPT ); Thu, 7 Apr 2011 12:54:15 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:60961 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019Ab1DGQyP (ORCPT ); Thu, 7 Apr 2011 12:54:15 -0400 Received: by fxm17 with SMTP id 17so1801734fxm.19 for ; Thu, 07 Apr 2011 09:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:mime-version :content-type:message-id; bh=Zepv/v7zLTn6Jc+5dm6PRjP+e6o0alSWYdWN4Z/EnW4=; b=X4QjykuAEiYRUNXboACC+LN4VvDOrmqJEW+Hc3QBS69zUTnz+NE584ryC4I7FAed6v srKg/rk71KoxL/pcePCQR7uxJMFbTmtuUrCYpohUzYsYAv2a8MxVpp/4e+E6FZBEUCNk uNaVk47ZCT9i7kHbYS2eNUzVFDdbvrNIK9W1U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:mime-version:content-type :message-id; b=ApWEyh49+lXjRJIeETCbSO9eos+3NaORtrCBIjiZ11HE9RZ8soId+1pmYgOUjXKOzJ IGMTuNiuCoKFtdddWrKi52kmmDcy6O5GaMo2rDSEsBkCe3xwqnEJgOZ+klctYtNuv/ID 6MRukCPn+bxmzCMMDALI8mfKgOkgjWIG+a6FE= Received: by 10.223.57.5 with SMTP id a5mr1139476fah.90.1302195253901; Thu, 07 Apr 2011 09:54:13 -0700 (PDT) Received: from bloomfield.localnet (pavelherrmann.kolej.mff.cuni.cz [78.128.197.20]) by mx.google.com with ESMTPS id n7sm536688fam.35.2011.04.07.09.54.12 (version=SSLv3 cipher=OTHER); Thu, 07 Apr 2011 09:54:12 -0700 (PDT) From: Pavel Herrmann To: linux-ide@vger.kernel.org Subject: [PATCH] support for PMP used in TT BlackX Duet drive dock Date: Thu, 7 Apr 2011 18:54:10 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.33-gentoo-r1; KDE/4.6.1; x86_64; ; ) MIME-Version: 1.0 Message-Id: <201104071854.10911.morpheus.ibis@gmail.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hi, Current linux kernel failes to communicate with PMP chip used in Thermaltake BlackX Duet (ST0015E) external drive, adding same quirks (some of them may not be necessary) as other chips have fixes it (tested on AHCI driver, on JMB363 and ICH10R) Please note that this patch is purposefully not in state includable in mainline, it is meant as a base for someone with more understanding of libata to make a proper fix Thanks Pavel Herrmann From f1c2e6ec61c978846d6d3dadacc7c1b2997140a6 Mon Sep 17 00:00:00 2001 From: Pavel Herrmann Date: Thu, 7 Apr 2011 18:15:26 +0200 Subject: [PATCH] libata-pmp: add support for Thermaltake BlackX Duet esata drive dock some errors still show up, but the dock works, both drives can be accessed at the same time the chip maker and designation is unknown - possibly jmicron JMB350? Signed-off-by: Pavel Herrmann --- drivers/ata/libata-pmp.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index 3120596..9ceef00 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -449,6 +449,14 @@ static void sata_pmp_quirks(struct ata_port *ap) * otherwise. Don't try hard to recover it. */ ap->pmp_link[ap->nr_pmp_links - 1].flags |= ATA_LFLAG_NO_RETRY; + } + } else if (vendor == 0x1095 && devid == 0x4726) { + /* chip found in Thermaltake BlackX Duet */ + ata_for_each_link(link, ap, EDGE) { + /* Use same quirks as sil chips to make it work */ + link->flags |= ATA_LFLAG_NO_LPM | + ATA_LFLAG_NO_SRST | + ATA_LFLAG_ASSUME_ATA; } } -- 1.7.4.1