| Message ID | 201009271809.44135.sshtylyov@ru.mvista.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
From: Sergei Shtylyov <sshtylyov@ru.mvista.com> Date: Mon, 27 Sep 2010 18:09:43 +0400 > DPLL clock (0x21) should be used for writes and PCI clock (0x23) for reads, > not vice versa. > > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Also applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: ide-2.6/drivers/ide/hpt366.c =================================================================== --- ide-2.6.orig/drivers/ide/hpt366.c +++ ide-2.6/drivers/ide/hpt366.c @@ -838,7 +838,7 @@ static void hpt3xxn_set_clock(ide_hwif_t static void hpt3xxn_rw_disk(ide_drive_t *drive, struct request *rq) { - hpt3xxn_set_clock(drive->hwif, rq_data_dir(rq) ? 0x23 : 0x21); + hpt3xxn_set_clock(drive->hwif, rq_data_dir(rq) ? 0x21 : 0x23); } /**
DPLL clock (0x21) should be used for writes and PCI clock (0x23) for reads, not vice versa. Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Cc: stable@kernel.org --- The patch is atop of ide-2.6.git tree. Not sure why I didn't fix this back in 2007... well, nobody has ever complained. :-) drivers/ide/hpt366.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html