From patchwork Sat Aug 21 08:43:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 62341 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 05CDEB70E0 for ; Sat, 21 Aug 2010 18:44:12 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616Ab0HUIoK (ORCPT ); Sat, 21 Aug 2010 04:44:10 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:42919 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592Ab0HUIoI (ORCPT ); Sat, 21 Aug 2010 04:44:08 -0400 Received: by wwi17 with SMTP id 17so5305863wwi.1 for ; Sat, 21 Aug 2010 01:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=3vopfdIq5+mJTuNtEYe/xa6kJFbsC4EpHOMBftWmt5k=; b=ZT2/DqE7uCKlGpPnARHXpLvybA5YoTHwWPdFZr6v+LB9/aEhWwDmZcw376XJBwagpy U/CrAbFI/tWsOMsSFtUKiBblPUFXPMtzBR3QaqeFhbo5AeTtwwlgDwOk3QehGtMpImBV 3krqzsS91f0x8jR+YhDgEtcHii7kTsytJ8Gus= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=nBvUNEuw/RQl1LPJcJxTVc8En1FJRiLIestGxzPAC5RFh8boXOKHDy+6InauB7pPmc UwhVuMIXZkrn4l4QiUHdklO3WgYaJ+QUcSbu9Nc8/quo7YgjNjLc1lujbxrJN56YQBW0 Zl5bx2mObG5JK60GbleCwVMKGxOhrDO4dx+3k= Received: by 10.216.7.78 with SMTP id 56mr352282weo.96.1282380247171; Sat, 21 Aug 2010 01:44:07 -0700 (PDT) Received: from bicker ([41.205.146.22]) by mx.google.com with ESMTPS id k7sm2332258wej.2.2010.08.21.01.43.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 21 Aug 2010 01:44:05 -0700 (PDT) Date: Sat, 21 Aug 2010 10:43:25 +0200 From: Dan Carpenter To: Jeff Garzik Cc: Stephen Rothwell , Rupjyoti Sarmah , Prodyut Hazarika , Grant Likely , linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] ata/sata_dwc_460ex: signdness bug Message-ID: <20100821084325.GF6674@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org dma_dwc_xfer_setup() returns an int and "dma_chan" needs to be signed for the error handling to work. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 2673a3d..6cf57c5 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1459,7 +1459,7 @@ static void sata_dwc_qc_prep_by_tag(struct ata_queued_cmd *qc, u8 tag) { struct scatterlist *sg = qc->sg; struct ata_port *ap = qc->ap; - u32 dma_chan; + int dma_chan; struct sata_dwc_device *hsdev = HSDEV_FROM_AP(ap); struct sata_dwc_device_port *hsdevp = HSDEVP_FROM_AP(ap); int err;