From patchwork Sat Apr 24 16:29:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 50912 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 25DFAB7D1E for ; Sun, 25 Apr 2010 02:30:48 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753816Ab0DXQar (ORCPT ); Sat, 24 Apr 2010 12:30:47 -0400 Received: from mail.dev.rtsoft.ru ([213.79.90.226]:47067 "HELO mail.dev.rtsoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752525Ab0DXQar (ORCPT ); Sat, 24 Apr 2010 12:30:47 -0400 Received: (qmail 16740 invoked from network); 24 Apr 2010 16:30:53 -0000 Received: from unknown (HELO wasted.dev.rtsoft.ru) (192.168.1.70) by 0 with SMTP; 24 Apr 2010 16:30:53 -0000 To: jgarzik@pobox.com Subject: [PATCH 2/2] pata_scc: kill useless check in scc_postreset() Cc: linux-ide@vger.kernel.org Content-Disposition: inline From: Sergei Shtylyov Organization: MontaVista Software Inc. Date: Sat, 24 Apr 2010 20:29:58 +0400 MIME-Version: 1.0 Message-Id: <201004242029.59003.sshtylyov@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org The device control register exists and its address is set by scc_setup_ports(), hence the check is useless... Signed-off-by: Sergei Shtylyov --- The patch is against the recent Linus' tree. drivers/ata/pata_scc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/drivers/ata/pata_scc.c =================================================================== --- linux-2.6.orig/drivers/ata/pata_scc.c +++ linux-2.6/drivers/ata/pata_scc.c @@ -903,8 +903,7 @@ static void scc_postreset(struct ata_lin } /* set up device control */ - if (ap->ioaddr.ctl_addr) - out_be32(ap->ioaddr.ctl_addr, ap->ctl); + out_be32(ap->ioaddr.ctl_addr, ap->ctl); DPRINTK("EXIT\n"); }